From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117099 invoked by alias); 28 Jan 2016 12:23:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 117080 invoked by uid 89); 28 Jan 2016 12:23:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=ass, sk:type_co, our X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 28 Jan 2016 12:23:26 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 364EAC0A9CE9; Thu, 28 Jan 2016 12:23:25 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u0SCNNol031122; Thu, 28 Jan 2016 07:23:24 -0500 Message-ID: <56AA083B.1060901@redhat.com> Date: Thu, 28 Jan 2016 12:23:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Walfred Tedeschi , eliz@gnu.org, brobecker@adacore.com CC: gdb-patches@sourceware.org Subject: Re: [PATCH V5 3/5] Add bound related fields to the siginfo structure References: <1453474456-13169-1-git-send-email-walfred.tedeschi@intel.com> <1453474456-13169-4-git-send-email-walfred.tedeschi@intel.com> In-Reply-To: <1453474456-13169-4-git-send-email-walfred.tedeschi@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-01/txt/msg00697.txt.bz2 On 01/22/2016 02:54 PM, Walfred Tedeschi wrote: > Both Linux and glibc have introduced bound related fields in the segmentation fault fields of the > siginfo_t type. Ass the new fields to our x86's siginfo_t type too. "Add the " ... > @@ -342,6 +344,18 @@ linux_get_siginfo_type_with_fields (struct gdbarch *gdbarch, > /* _sigfault */ > type = arch_composite_type (gdbarch, NULL, TYPE_CODE_STRUCT); > append_composite_type_field (type, "si_addr", void_ptr_type); > + > + /* additional bound fields for _sigfault in case they are added. */ "Additional", uppercase. "in case they were requested.". > + if ((extra_fields & LINUX_SIGINFO_FIELD_ADDR_BND) != 0) > + { OK with those changes. Thanks, Pedro Alves