From: Pedro Alves <palves@redhat.com>
To: Walfred Tedeschi <walfred.tedeschi@intel.com>,
eliz@gnu.org, brobecker@adacore.com
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH V5 4/5] Adaptation of siginfo fixup for the new bnd fields
Date: Thu, 28 Jan 2016 12:37:00 -0000 [thread overview]
Message-ID: <56AA0B6F.4070102@redhat.com> (raw)
In-Reply-To: <1453474456-13169-5-git-send-email-walfred.tedeschi@intel.com>
On 01/22/2016 02:54 PM, Walfred Tedeschi wrote:
> Caveat: No support for MPX on x32.
What would it take to support that?
> +/* These types below (native_*) define a siginfo type that is layout
> + the most complete siginfo available for the architecture. */
nat_, not native_, afaics. I'd copy/edit this to:
/* The nat_* types below define the most complete kernel siginfo type
known for the architecture, independent of system/libc headers. */
> +
> +typedef int nat_int_t;
> +typedef void* nat_uptr_t;
> +
> +typedef int nat_time_t;
> +typedef int nat_timer_t;
> +
>
> @@ -192,54 +287,58 @@ typedef struct compat_x32_siginfo
> static void
> compat_siginfo_from_siginfo (compat_siginfo_t *to, siginfo_t *from)
> {
> + nat_siginfo_t from_nat;
> +
> + gdb_assert (sizeof (nat_siginfo_t) == sizeof (siginfo_t));
Make this a gdb_static_assert, and move it out of the function, below
where nat_siginfo_t is defined. (Likewise the other instances in the
other functions).
OK with those changes.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-01-28 12:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 15:36 [PATCH V5 0/5] Intel MPX bound violation support Walfred Tedeschi
2016-01-22 15:17 ` [PATCH V5 1/5] Preparation for new siginfo on Linux Walfred Tedeschi
2016-01-28 12:20 ` Pedro Alves
2016-01-22 15:17 ` [PATCH V5 3/5] Add bound related fields to the siginfo structure Walfred Tedeschi
2016-01-28 12:23 ` Pedro Alves
2016-01-22 15:17 ` [PATCH V5 4/5] Adaptation of siginfo fixup for the new bnd fields Walfred Tedeschi
2016-01-28 12:37 ` Pedro Alves [this message]
2016-02-02 10:31 ` Pedro Alves
2016-02-02 13:58 ` Walfred Tedeschi
2016-01-22 15:18 ` [PATCH V5 2/5] Use linux_get_siginfo_type_with_fields for x86 Walfred Tedeschi
2016-01-28 12:19 ` Pedro Alves
2016-01-22 15:18 ` [PATCH V5 5/5] ntel MPX bound violation handling Walfred Tedeschi
2016-01-28 13:43 ` Pedro Alves
2016-01-28 13:49 ` Walfred Tedeschi
2016-01-28 14:18 ` Pedro Alves
2016-02-02 10:09 ` Walfred Tedeschi
2016-02-02 10:38 ` Pedro Alves
2016-02-02 10:41 ` Walfred Tedeschi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AA0B6F.4070102@redhat.com \
--to=palves@redhat.com \
--cc=brobecker@adacore.com \
--cc=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=walfred.tedeschi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).