From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106488 invoked by alias); 1 Feb 2016 12:05:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106476 invoked by uid 89); 1 Feb 2016 12:05:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=sk:forking X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 01 Feb 2016 12:05:35 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id D798D19F25E; Mon, 1 Feb 2016 12:05:33 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u11C5Vd4019651; Mon, 1 Feb 2016 07:05:32 -0500 Message-ID: <56AF4A0B.7030102@redhat.com> Date: Mon, 01 Feb 2016 12:05:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Don Breazeal , gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] PR remote/19496, timeout in forking-threads-plus-bkpt References: <1453942111-1215-1-git-send-email-donb@codesourcery.com> <1453942111-1215-4-git-send-email-donb@codesourcery.com> In-Reply-To: <1453942111-1215-4-git-send-email-donb@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-02/txt/msg00007.txt.bz2 On 01/28/2016 12:48 AM, Don Breazeal wrote: > > --- > gdb/infrun.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/gdb/infrun.c b/gdb/infrun.c > index 15210c9..e324864 100644 > --- a/gdb/infrun.c > +++ b/gdb/infrun.c > @@ -5232,7 +5232,13 @@ Cannot fill $_exitsignal with the correct signal number.\n")); > ecs->ptid = inferior_ptid; > > if (should_resume) > - keep_going (ecs); > + { > + /* Make sure the thread is marked as running. If the event > + occurred in the thread before we added it, it may have > + never been marked running. */ > + set_running (inferior_ptid, 1); > + keep_going (ecs); > + } > else > stop_waiting (ecs); > return; > Can you check whether this is still needed in current master? Specifically, whether a2077e254098 ([PATCH] Fix PR 19461: strange "info thread" behavior in non-stop) already fixed this? See: https://sourceware.org/ml/gdb-patches/2016-01/msg00446.html https://sourceware.org/bugzilla/show_bug.cgi?id=19461 Thanks, Pedro Alves