From: Pedro Alves <palves@redhat.com>
To: Don Breazeal <donb@codesourcery.com>,
"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [PATCH 3/3] PR remote/19496, timeout in forking-threads-plus-bkpt
Date: Mon, 01 Feb 2016 20:09:00 -0000 [thread overview]
Message-ID: <56AFBB80.1010209@redhat.com> (raw)
In-Reply-To: <56AFB22A.6010006@codesourcery.com>
On 02/01/2016 07:29 PM, Don Breazeal wrote:
> On 2/1/2016 4:05 AM, Pedro Alves wrote:
> Hi Pedro,
> It looks like my patch is still needed. FYI, the values of the
> variables used to determine whether to call set_running in your patch
> are this, in my failing test case:
>
> follow_child 0
> detach_fork 1
> non_stop 1
> sched_multi 0
> target_is_non_stop_p () 1
Hmm.
> A fork event was reported to GDB before GDB knew about the parent thread,
> followed immediately by a breakpoint event in a different thread. The
> parent thread was subsequently added via remote_notice_new_inferior in
> process_stop_reply, but when the thread was added the thread_info.state
> was set to THREAD_STOPPED. The fork event was then handled correctly,
> but when the fork parent was resumed via a call to keep_going, the state
> was unchanged.
Since this is non-stop, then it sounds to me like the bug is that the
thread should have been added in THREAD_RUNNING state.
Consider that infrun may be pulling target events out of the target_ops
backend into its own event queue, but, not process them immediately.
E.g., infrun may be stopping all threads temporarily for a step-over-breakpoint
operation for thread A (stop_all_threads). The waitstatus of all threads
is thus left pending in the thread structure (save_status), including the
fork event of thread B. Right at this point, if the user
does "info threads", that should show thread B (the fork parent) running,
not stopped, even if internally, gdb is holding it paused for a little bit.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-02-01 20:09 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 0:48 [PATCH 0/3] PR remote/19496, remote fork failures Don Breazeal
2016-01-28 0:48 ` [PATCH 3/3] PR remote/19496, timeout in forking-threads-plus-bkpt Don Breazeal
2016-02-01 12:05 ` Pedro Alves
2016-02-01 19:29 ` Don Breazeal
2016-02-01 20:09 ` Pedro Alves [this message]
2016-02-11 0:28 ` [PATCH v2 " Don Breazeal
2016-02-25 17:29 ` [PING]Re: " Don Breazeal
2016-03-03 18:20 ` [PING] " Don Breazeal
2016-03-14 21:30 ` Don Breazeal
2016-03-15 15:30 ` Pedro Alves
2016-03-16 17:29 ` Don Breazeal
2016-03-16 22:51 ` Don Breazeal
2016-03-17 10:38 ` Pedro Alves
2016-02-11 0:28 ` [PATCH v2 2/3] PR remote/19496, interrupted syscall " Don Breazeal
2016-02-25 17:28 ` Don Breazeal
2016-03-03 18:19 ` [PING] " Don Breazeal
2016-03-14 21:29 ` Don Breazeal
2016-03-15 12:55 ` Pedro Alves
2016-03-16 18:26 ` Don Breazeal
2016-03-16 18:33 ` Pedro Alves
2016-03-16 22:18 ` Don Breazeal
2016-01-28 0:48 ` [PATCH " Don Breazeal
2016-02-01 19:38 ` Pedro Alves
2016-01-28 0:48 ` [PATCH 1/3] PR remote/19496, internal err forking-threads-plus-bkpt Don Breazeal
2016-02-01 19:26 ` [pushed] Test gdb.threads/forking-threads-plus-breakpoint.exp with, displaced stepping off (Re: [PATCH 1/3] PR remote/19496, internal err forking-threads-plus-bkpt) Pedro Alves
2016-02-01 20:38 ` [PATCH 1/3] PR remote/19496, internal err forking-threads-plus-bkpt Pedro Alves
2016-02-11 0:26 ` [PATCH v2 " Don Breazeal
2016-02-12 20:15 ` Pedro Alves
2016-02-16 17:21 ` Don Breazeal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56AFBB80.1010209@redhat.com \
--to=palves@redhat.com \
--cc=donb@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).