From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79278 invoked by alias); 1 Feb 2016 20:09:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79260 invoked by uid 89); 1 Feb 2016 20:09:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=paused, sk:stepov, sk:step-ov, sk:forking X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 01 Feb 2016 20:09:39 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 2116F8E375; Mon, 1 Feb 2016 20:09:38 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u11K9aKB025360; Mon, 1 Feb 2016 15:09:37 -0500 Message-ID: <56AFBB80.1010209@redhat.com> Date: Mon, 01 Feb 2016 20:09:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Don Breazeal , "gdb-patches@sourceware.org" Subject: Re: [PATCH 3/3] PR remote/19496, timeout in forking-threads-plus-bkpt References: <1453942111-1215-1-git-send-email-donb@codesourcery.com> <1453942111-1215-4-git-send-email-donb@codesourcery.com> <56AF4A0B.7030102@redhat.com> <56AFB22A.6010006@codesourcery.com> In-Reply-To: <56AFB22A.6010006@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-02/txt/msg00021.txt.bz2 On 02/01/2016 07:29 PM, Don Breazeal wrote: > On 2/1/2016 4:05 AM, Pedro Alves wrote: > Hi Pedro, > It looks like my patch is still needed. FYI, the values of the > variables used to determine whether to call set_running in your patch > are this, in my failing test case: > > follow_child 0 > detach_fork 1 > non_stop 1 > sched_multi 0 > target_is_non_stop_p () 1 Hmm. > A fork event was reported to GDB before GDB knew about the parent thread, > followed immediately by a breakpoint event in a different thread. The > parent thread was subsequently added via remote_notice_new_inferior in > process_stop_reply, but when the thread was added the thread_info.state > was set to THREAD_STOPPED. The fork event was then handled correctly, > but when the fork parent was resumed via a call to keep_going, the state > was unchanged. Since this is non-stop, then it sounds to me like the bug is that the thread should have been added in THREAD_RUNNING state. Consider that infrun may be pulling target events out of the target_ops backend into its own event queue, but, not process them immediately. E.g., infrun may be stopping all threads temporarily for a step-over-breakpoint operation for thread A (stop_all_threads). The waitstatus of all threads is thus left pending in the thread structure (save_status), including the fork event of thread B. Right at this point, if the user does "info threads", that should show thread B (the fork parent) running, not stopped, even if internally, gdb is holding it paused for a little bit. Thanks, Pedro Alves