public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Keith Seitz <keiths@redhat.com>
To: "gdb-patches@sourceware.org ml" <gdb-patches@sourceware.org>
Cc: yao.qui@linaro.org
Subject: Re: [RFC] breakpoints/19474 [was Re: RFC: branching for GDB 7.11 soon? (possibly Wed)]
Date: Thu, 04 Feb 2016 01:33:00 -0000	[thread overview]
Message-ID: <56B2AA63.3060004@redhat.com> (raw)
In-Reply-To: <56B29F17.6020603@redhat.com>

On 02/03/2016 04:45 PM, Keith Seitz wrote:
> Anyone have a better idea?

Well, same idea, but slightly faster...

> +  /* Iterate through the symtabs, searching for matches to FULLNAME.  */
> +  for (ix = 0; VEC_iterate (symtab_ptr, symtabs, ix, symtab); ++ix)
> +    {
> +      const char *basename = lbasename (fullname);
> +      char *symtab_with_dir;
> +
> +      if (SYMTAB_DIRNAME (symtab) == NULL)
> +	continue;
> +
> +      symtab_with_dir = concat (SYMTAB_DIRNAME (symtab), SLASH_STRING,
> +				basename, NULL);

I think that the base name of the default symtab will be the same as the
base name of any collected symtabs, so we need only really compare
directory names here.

Any other ideas?

Keith

  reply	other threads:[~2016-02-04  1:33 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-01  3:06 RFC: branching for GDB 7.11 soon? (possibly Wed) Joel Brobecker
2016-02-01 13:34 ` Pedro Alves
2016-02-01 17:04   ` Pedro Alves
2016-02-01 19:51 ` Keith Seitz
2016-02-04  0:45   ` [RFC] breakpoints/19474 [was Re: RFC: branching for GDB 7.11 soon? (possibly Wed)] Keith Seitz
2016-02-04  1:33     ` Keith Seitz [this message]
2016-02-04 11:05     ` Yao Qi
2016-02-04 12:31     ` Pedro Alves
2016-08-12 12:00       ` Yao Qi
2016-02-07  8:12 ` RFC: branching for GDB 7.11 soon? (possibly Wed) Joel Brobecker
2016-02-08 18:03   ` Sergio Durigan Junior
2016-02-08 19:28   ` Keith Seitz
2016-02-08 20:06     ` Pedro Alves
2016-02-08 20:11       ` Keith Seitz
2016-02-09  5:35   ` Sergio Durigan Junior
2016-02-09 14:15     ` Simon Marchi
2016-02-09 14:18       ` Pedro Alves
2016-02-09 14:52         ` Simon Marchi
2016-02-09 18:31           ` Sergio Durigan Junior
2016-02-09 11:56   ` Joel Brobecker
2016-02-09 12:37     ` Pedro Alves
2016-02-09 22:37       ` Keith Seitz
2016-02-10  3:40     ` Joel Brobecker
2016-02-10 10:04       ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B2AA63.3060004@redhat.com \
    --to=keiths@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=yao.qui@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).