From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21083 invoked by alias); 4 Feb 2016 01:33:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20163 invoked by uid 89); 4 Feb 2016 01:33:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:769, Anyone X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 04 Feb 2016 01:33:25 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id BCF598E91B; Thu, 4 Feb 2016 01:33:24 +0000 (UTC) Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u141XN54012618 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 3 Feb 2016 20:33:24 -0500 Subject: Re: [RFC] breakpoints/19474 [was Re: RFC: branching for GDB 7.11 soon? (possibly Wed)] To: "gdb-patches@sourceware.org ml" References: <20160201030638.GG4008@adacore.com> <56AFB750.3030702@redhat.com> <56B29F17.6020603@redhat.com> Cc: yao.qui@linaro.org From: Keith Seitz Message-ID: <56B2AA63.3060004@redhat.com> Date: Thu, 04 Feb 2016 01:33:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <56B29F17.6020603@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00103.txt.bz2 On 02/03/2016 04:45 PM, Keith Seitz wrote: > Anyone have a better idea? Well, same idea, but slightly faster... > + /* Iterate through the symtabs, searching for matches to FULLNAME. */ > + for (ix = 0; VEC_iterate (symtab_ptr, symtabs, ix, symtab); ++ix) > + { > + const char *basename = lbasename (fullname); > + char *symtab_with_dir; > + > + if (SYMTAB_DIRNAME (symtab) == NULL) > + continue; > + > + symtab_with_dir = concat (SYMTAB_DIRNAME (symtab), SLASH_STRING, > + basename, NULL); I think that the base name of the default symtab will be the same as the base name of any collected symtabs, so we need only really compare directory names here. Any other ideas? Keith