From: Antoine Tremblay <antoine.tremblay@ericsson.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: <gdb-patches@sourceware.org>, Pierre Langlois <pierre.langlois@arm.com>
Subject: Re: [PATCH 4/8] Implement target_emit_ops
Date: Mon, 08 Feb 2016 17:59:00 -0000 [thread overview]
Message-ID: <56B8D77D.8040000@ericsson.com> (raw)
In-Reply-To: <86oabrnm8k.fsf@gmail.com>
On 02/08/2016 12:30 PM, Yao Qi wrote:
> Antoine Tremblay <antoine.tremblay@ericsson.com> writes:
>
>> I'm wondering is there a reason we don't use gcc to generate the
>> native bytecode like done on x86 ?
>>
>> x86 has a macro like so :
>>
>> #define EMIT_ASM(NAME, INSNS)
>> do
>> {
>> extern unsigned char start_ ## NAME, end_ ## NAME;
>> add_insns (&start_ ## NAME, &end_ ## NAME - &start_ ## NAME);
>> __asm__ ("jmp end_" #NAME "\n"
>> "\t" "start_" #NAME ":"
>> "\t" INSNS "\n"
>> "\t" "end_" #NAME ":");
>> } while (0)
>>
>
> The reason is about the code readability. We find the way we are using
> in aarch64 is more readable than the way for x86.
>
OK.
> p += emit_stp (p, x0, x1, sp, preindex_memory_operand (-2 * 16));
> p += emit_str (p, lr, sp, offset_memory_operand (3 * 8));
> p += emit_str (p, fp, sp, offset_memory_operand (2 * 8));
> p += emit_add (p, fp, sp, immediate_operand (2 * 8));
>
> vs.
>
> EMIT_ASM (amd64_prologue,
> "pushq %rbp\n\t"
> "movq %rsp,%rbp\n\t"
> "sub $0x20,%rsp\n\t"
> "movq %rdi,-8(%rbp)\n\t"
> "movq %rsi,-16(%rbp)");
>
>> Could the same be done for armv7 or there's a reason that prevents it ?
>>
>
> No reason prevents it, but the code should be readable.
>
OK thanks, It is readable that way but I think I'll go with EMIT_ASM...
given that this should save me quite a bit of time considering thumb/arm
versions and that there's not much emit_ functions done at the moment.
It should still be readable.
Regards,
Antoine
next prev parent reply other threads:[~2016-02-08 17:59 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 11:31 [PATCH 0/8] [AArch64] Support fast tracepoints Pierre Langlois
2015-09-14 11:31 ` [PATCH 3/8] [AArch64] Make aarch64_decode_adrp handle both ADR and ADRP instructions Pierre Langlois
2015-09-15 10:12 ` Yao Qi
2015-09-15 12:05 ` [PATCH 3/8 v2] " Pierre Langlois
2015-09-14 11:31 ` [PATCH 1/8] [AArch64] Use debug_printf instead of fprintf_unfiltered Pierre Langlois
2015-09-15 10:06 ` Yao Qi
2015-09-15 11:07 ` Pierre Langlois
2015-09-15 11:19 ` Yao Qi
2015-09-15 11:43 ` [PATCH 2/8 v2] " Pierre Langlois
2015-09-15 17:40 ` Pierre Langlois
2015-09-14 11:32 ` [PATCH 5/8] [GDBserver][AArch64] Implement target_emit_ops Pierre Langlois
2015-09-14 11:32 ` [PATCH 6/8] [testsuite][AArch64] Enable fast tracepoint tests Pierre Langlois
2015-09-15 10:18 ` Yao Qi
2015-09-14 11:32 ` [PATCH 7/8] [testsuite] Add a gdb.trace test for instruction relocation Pierre Langlois
2015-09-15 11:27 ` Yao Qi
2015-09-14 11:33 ` [PATCH 4/8] [GDBserver][AArch64] Add support for fast tracepoints Pierre Langlois
2015-09-15 13:01 ` Yao Qi
2015-09-14 11:38 ` [PATCH 2/8] [AArch64] Move instruction decoding into new arch/ directory Pierre Langlois
2015-09-15 10:10 ` Yao Qi
2015-09-15 12:02 ` [PATCH 2/8 v2] " Pierre Langlois
2015-09-14 11:38 ` [PATCH 8/8] [testsuite] Add a test case for fast tracepoints' locking mechanism Pierre Langlois
2015-09-14 16:45 ` [PATCH] Add NEWS entry for fast tracepoint support on aarch64-linux Pierre Langlois
2015-09-18 12:43 ` [PATCH 0/8 V2] [AArch64] Support fast tracepoints Yao Qi
2015-09-18 12:43 ` [PATCH 4/8] Implement target_emit_ops Yao Qi
2015-09-18 12:57 ` Pierre Langlois
2016-02-05 20:09 ` Antoine Tremblay
2016-02-08 17:30 ` Yao Qi
2016-02-08 17:59 ` Antoine Tremblay [this message]
2015-09-18 12:43 ` [PATCH 8/8] Add NEWS entry for fast tracepoint support on aarch64-linux Yao Qi
2015-09-18 14:07 ` Eli Zaretskii
2015-09-18 12:43 ` [PATCH 5/8] Enable fast tracepoint tests Yao Qi
2015-09-18 12:43 ` [PATCH 1/8] Move instruction decoding into new arch/ directory Yao Qi
2015-09-18 12:43 ` [PATCH 2/8] Make aarch64_decode_adrp handle both ADR and ADRP instructions Yao Qi
2015-09-18 12:43 ` [PATCH 7/8] Add a test case for fast tracepoints' locking mechanism Yao Qi
2015-09-18 12:44 ` [PATCH 6/8] Add a gdb.trace test for instruction relocation Yao Qi
2015-09-18 12:44 ` [PATCH 3/8] Add support for fast tracepoints Yao Qi
2015-09-21 14:06 ` [PATCH 0/8 V2] [AArch64] Support " Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B8D77D.8040000@ericsson.com \
--to=antoine.tremblay@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=pierre.langlois@arm.com \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).