From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22123 invoked by alias); 8 Feb 2016 20:06:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 22106 invoked by uid 89); 8 Feb 2016 20:06:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=charged X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 08 Feb 2016 20:06:42 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 9984614CAB0; Mon, 8 Feb 2016 20:06:41 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u18K6eu8032368; Mon, 8 Feb 2016 15:06:40 -0500 Message-ID: <56B8F550.4020506@redhat.com> Date: Mon, 08 Feb 2016 20:06:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Keith Seitz , Joel Brobecker , "gdb-patches@sourceware.org ml" Subject: Re: RFC: branching for GDB 7.11 soon? (possibly Wed) References: <20160201030638.GG4008@adacore.com> <20160207081230.GA20874@adacore.com> <56B8EC41.7080004@redhat.com> In-Reply-To: <56B8EC41.7080004@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-02/txt/msg00205.txt.bz2 On 02/08/2016 07:28 PM, Keith Seitz wrote: > I looked at this over the weekend and updated the bz. It seems pretty > trivial, and the patch is very safe to use. > > In short, update_breakpoints_after_exec is charged with deleting any > breakpoint with no location. momentary_breakpoint types were implemented > to rely on this behavior. So b->location can be NULL, contrary to what I > previously assumed. > > Simply handling NULL in location_empty_p fixes this. > > Writing a test for this now. Thanks Keith. Having the testsuite cover this would be great. BTW, calling both b->location and the b->loc things "locations" is ambiguous and confusing, IMO. How about we start calling the new b->location, the "location spec" ? Thanks, Pedro Alves