From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124679 invoked by alias); 10 Feb 2016 13:31:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124666 invoked by uid 89); 10 Feb 2016 13:31:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=mmx, reaching, HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 10 Feb 2016 13:31:25 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 5AB9BC0A1603; Wed, 10 Feb 2016 13:31:24 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1ADVNgv004396; Wed, 10 Feb 2016 08:31:23 -0500 Message-ID: <56BB3BAA.3050908@redhat.com> Date: Wed, 10 Feb 2016 13:31:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: =?UTF-8?B?TWFyY2luIEtvxZtjaWVsbmlja2k=?= , gdb-patches@sourceware.org Subject: Re: [PATCH 5/6] gdb/x86: Implement ax_pseudo_register_collect hook. References: <1454773157-31569-1-git-send-email-koriakin@0x04.net> <1454792070-25410-1-git-send-email-koriakin@0x04.net> In-Reply-To: <1454792070-25410-1-git-send-email-koriakin@0x04.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2016-02/txt/msg00283.txt.bz2 Great stuff. Minor comments follow... Patch is missing intro comments to new functions: /* Implementation of foo. / See foo.h. / etc. */ On 02/06/2016 08:54 PM, Marcin Kościelnicki wrote: > +static int > +amd64_ax_pseudo_register_collect (struct gdbarch *gdbarch, > + struct agent_expr *ax, int regnum) > +{ > + struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); Empty line after decl here. > +int > +i386_ax_pseudo_register_collect (struct gdbarch *gdbarch, > + struct agent_expr *ax, int regnum) > +{ > + struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); Ditto. > + if (i386_mmx_regnum_p (gdbarch, regnum)) > + { > + /* MMX to FPU register mapping depends on current TOS. Let's just > + not care and collect everything... */ > + int i; Ditto. (several instances more in the function) > + ax_reg_mask (ax, I387_FSTAT_REGNUM (tdep)); > + for (i = 0; i < 8; i++) > + ax_reg_mask (ax, I387_ST0_REGNUM (tdep) + i); > + return 0; > + } > + else if (i386_byte_regnum_p (gdbarch, regnum)) > + { > + /* Check byte pseudo registers last since this function will > + be called from amd64_ax_pseudo_register_collect, which handles > + byte pseudo registers differently. */ I don't understand this comment. amd64_ax_pseudo_register_collect checks i386_byte_regnum_p before ever reaching here, afaics. > + int gpnum = regnum - tdep->al_regnum; > + ax_reg_mask (ax, gpnum % 4); > + return 0; > + } > + else > + internal_error (__FILE__, __LINE__, _("invalid regnum")); > + return 1; > +} Thanks, Pedro Alves