From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41002 invoked by alias); 10 Feb 2016 14:28:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 40987 invoked by uid 89); 10 Feb 2016 14:28:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Makes, Hx-languages-length:691, HContent-Transfer-Encoding:8bit X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 10 Feb 2016 14:28:39 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id BC6AD14CAB5; Wed, 10 Feb 2016 14:28:38 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1AESbeA015179; Wed, 10 Feb 2016 09:28:38 -0500 Message-ID: <56BB4915.1020307@redhat.com> Date: Wed, 10 Feb 2016 14:28:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: =?UTF-8?B?TWFyY2luIEtvxZtjaWVsbmlja2k=?= CC: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/x86: Implement ax_pseudo_register_collect hook. References: <56BB4030.3040600@redhat.com> <1455114446-25583-1-git-send-email-koriakin@0x04.net> In-Reply-To: <1455114446-25583-1-git-send-email-koriakin@0x04.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2016-02/txt/msg00294.txt.bz2 On 02/10/2016 02:27 PM, Marcin Kościelnicki wrote: > Makes "collect $ymm15" action work. > > gdb/ChangeLog: > > * amd64-tdep.c (amd64_ax_pseudo_register_collect): New function. > (amd64_init_abi): Fill ax_pseudo_register_collect hook. > * gdb/i386-tdep.c (i386_pseudo_register_read_into_value): Remove > misleading comment. > (i386_pseudo_register_write): Ditto. > (i386_ax_pseudo_register_collect): New function. > (i386_gdbarch_init): Fill ax_pseudo_register_collect hook. > * i386-tdep.h: Add i386_ax_pseudo_register_collect prototype. > --- > Fixed, misleading comments removed. OK to push now? OK. Thanks, Pedro Alves