From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105296 invoked by alias); 11 Feb 2016 14:17:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 105263 invoked by uid 89); 11 Feb 2016 14:17:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: xyzzy.0x04.net Received: from xyzzy.0x04.net (HELO xyzzy.0x04.net) (109.74.193.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Feb 2016 14:17:24 +0000 Received: from hogfather.0x04.net (89-65-66-135.dynamic.chello.pl [89.65.66.135]) by xyzzy.0x04.net (Postfix) with ESMTPS id 368D33FEC0; Thu, 11 Feb 2016 15:18:12 +0100 (CET) Received: from [192.168.13.108] (89-65-66-135.dynamic.chello.pl [89.65.66.135]) by hogfather.0x04.net (Postfix) with ESMTPSA id 05EDD580088; Thu, 11 Feb 2016 15:17:21 +0100 (CET) Subject: Re: [PATCH] gdb.trace: Add a testcase for tdesc in tfile. To: Pedro Alves References: <56BB4004.1090708@redhat.com> <1455185675-27574-1-git-send-email-koriakin@0x04.net> <56BC85E8.6010409@redhat.com> Cc: gdb-patches@sourceware.org From: =?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?= Message-ID: <56BC97F1.3020108@0x04.net> Date: Thu, 11 Feb 2016 14:17:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56BC85E8.6010409@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00349.txt.bz2 On 11/02/16 14:00, Pedro Alves wrote: > On 02/11/2016 10:14 AM, Marcin Kościelnicki wrote: >> This tests whether $ymm15 can be correctly collected and printed from >> tfile. It covers: >> >> - storing tdesc in tfile (without that, $ymm15 doesn't exist) >> - ax_pseudo_register_collect for x86 (without that, $ymm15 cannot be >> collected) >> - register order in tfile_fetch_registers (without that, $ymm15h is >> fetched from wrong position) >> - off-by-one in tfile_fetch_registers (without that, $ymm15h is >> incorrectly considered to be out of bounds) >> - using proper tdesc in encoding tracepoint actions (without that, >> internal error happens due to $ymm15h being > > OK once prereqs are in. > > Thanks, > Pedro Alves > Thanks, pushed.