From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73161 invoked by alias); 11 Feb 2016 16:50:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 73142 invoked by uid 89); 11 Feb 2016 16:50:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:3012, Period, t*, hey X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 11 Feb 2016 16:50:22 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 9380A19F241; Thu, 11 Feb 2016 16:50:21 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1BGoKL3020911; Thu, 11 Feb 2016 11:50:20 -0500 Message-ID: <56BCBBCB.8050901@redhat.com> Date: Thu, 11 Feb 2016 16:50:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: =?UTF-8?B?TWFyY2luIEtvxZtjaWVsbmlja2k=?= CC: gdb-patches@sourceware.org, antoine.tremblay@ericsson.com Subject: Re: [PATCH] gdbserver: Remove tracepoint_action ops. References: <56A60CD3.6060704@redhat.com> <1455208203-28310-1-git-send-email-koriakin@0x04.net> In-Reply-To: <1455208203-28310-1-git-send-email-koriakin@0x04.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2016-02/txt/msg00372.txt.bz2 On 02/11/2016 04:30 PM, Marcin Kościelnicki wrote: > 2015-06-27 Wei-cheng Wang > 2016-02-11 Marcin Kościelnicki Only one date, and then align names: 2015-06-27 Wei-cheng Wang Marcin Kościelnicki See previous examples: $ grep -P "\t.*@" gdb/ChangeLog-2015 -C 3 | less > > * tracepoint.c (struct tracepoint_action_ops): Removed. "Remove." > (struct tracepoint_action): Remove ops. > (m_tracepoint_action_download, r_tracepoint_action_download, > x_tracepoint_action_download, l_tracepoint_action_download): Adjust > size and offset accordingly. Split lines with close/open ()s: (m_tracepoint_action_download, r_tracepoint_action_download) (x_tracepoint_action_download, l_tracepoint_action_download): Adjust size and offset accordingly. > (m_tracepoint_action_ops, r_tracepoint_action_ops, > x_tracepoint_action_ops, l_tracepoint_action_ops): Delete Ditto. Period at end: (m_tracepoint_action_ops, r_tracepoint_action_ops) (x_tracepoint_action_ops, l_tracepoint_action_ops): Delete. > (tracepoint_action_send, tracepoint_action_download): New functions. > Helpers for tracetion action handlers. Typo "tracetion". > (add_tracepoint_action): Remove setup actions ops. > (download_tracepoint_1, tracepoint_send_agent): Call helper functions. > --- > Hey, > > This is a fixed-up version of Wei-cheng's patch at > https://sourceware.org/ml/gdb-patches/2015-03/msg00995.html . > > This version, in addition to fixing a few trivial conflicts, also removes > the definition of struct tracepoint_action_ops, which is now unused, but > was left in by the original patch. Thanks. > > I'm also not sure if I got the changelog format right... > > OK to push? > OK with fixes below. > - > static CORE_ADDR > r_tracepoint_action_download (const struct tracepoint_action *action) > { > - int size_in_ipa = (sizeof (struct collect_registers_action) > - - offsetof (struct tracepoint_action, type)); > - CORE_ADDR ipa_action = target_malloc (size_in_ipa); > + CORE_ADDR ipa_action = target_malloc (sizeof (struct collect_registers_action)); > Remove spurious double-space before '=' while at it. > @@ -628,21 +592,14 @@ x_tracepoint_action_send ( char *buffer, const struct tracepoint_action *action) > return agent_expr_send (buffer, eaction->expr); > } > > -static const struct tracepoint_action_ops x_tracepoint_action_ops = > -{ > - x_tracepoint_action_download, > - x_tracepoint_action_send, > -}; > - > static CORE_ADDR > l_tracepoint_action_download (const struct tracepoint_action *action) > { > - int size_in_ipa = (sizeof (struct collect_static_trace_data_action) > - - offsetof (struct tracepoint_action, type)); > - CORE_ADDR ipa_action = target_malloc (size_in_ipa); > + CORE_ADDR ipa_action = > + target_malloc (sizeof (struct collect_static_trace_data_action)); The '=' goes at the beginning of the next line. OK with those fixed. Thanks, Pedro Alves