From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71221 invoked by alias); 11 Feb 2016 22:24:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 69918 invoked by uid 89); 11 Feb 2016 22:24:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=hey X-HELO: xyzzy.0x04.net Received: from xyzzy.0x04.net (HELO xyzzy.0x04.net) (109.74.193.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Feb 2016 22:24:12 +0000 Received: from hogfather.0x04.net (89-65-66-135.dynamic.chello.pl [89.65.66.135]) by xyzzy.0x04.net (Postfix) with ESMTPS id C95903FEC0; Thu, 11 Feb 2016 23:25:00 +0100 (CET) Received: from [192.168.13.108] (89-65-66-135.dynamic.chello.pl [89.65.66.135]) by hogfather.0x04.net (Postfix) with ESMTPSA id 77336580088; Thu, 11 Feb 2016 23:24:10 +0100 (CET) Subject: Re: [PATCH] gdbserver: Remove tracepoint_action ops. To: Pedro Alves References: <56A60CD3.6060704@redhat.com> <1455208203-28310-1-git-send-email-koriakin@0x04.net> <56BCBBCB.8050901@redhat.com> Cc: gdb-patches@sourceware.org, antoine.tremblay@ericsson.com From: =?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?= Message-ID: <56BD0A0A.6010208@0x04.net> Date: Thu, 11 Feb 2016 22:24:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56BCBBCB.8050901@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00392.txt.bz2 On 11/02/16 17:50, Pedro Alves wrote: > On 02/11/2016 04:30 PM, Marcin Kościelnicki wrote: > >> 2015-06-27 Wei-cheng Wang >> 2016-02-11 Marcin Kościelnicki > > Only one date, and then align names: > > 2015-06-27 Wei-cheng Wang > Marcin Kościelnicki > > See previous examples: > > $ grep -P "\t.*@" gdb/ChangeLog-2015 -C 3 | less > > >> >> * tracepoint.c (struct tracepoint_action_ops): Removed. > > "Remove." > >> (struct tracepoint_action): Remove ops. >> (m_tracepoint_action_download, r_tracepoint_action_download, >> x_tracepoint_action_download, l_tracepoint_action_download): Adjust >> size and offset accordingly. > > Split lines with close/open ()s: > > (m_tracepoint_action_download, r_tracepoint_action_download) > (x_tracepoint_action_download, l_tracepoint_action_download): Adjust > size and offset accordingly. > > >> (m_tracepoint_action_ops, r_tracepoint_action_ops, >> x_tracepoint_action_ops, l_tracepoint_action_ops): Delete > > Ditto. Period at end: > > (m_tracepoint_action_ops, r_tracepoint_action_ops) > (x_tracepoint_action_ops, l_tracepoint_action_ops): Delete. > > >> (tracepoint_action_send, tracepoint_action_download): New functions. >> Helpers for tracetion action handlers. > > Typo "tracetion". > > >> (add_tracepoint_action): Remove setup actions ops. >> (download_tracepoint_1, tracepoint_send_agent): Call helper functions. >> --- >> Hey, >> >> This is a fixed-up version of Wei-cheng's patch at >> https://sourceware.org/ml/gdb-patches/2015-03/msg00995.html . >> >> This version, in addition to fixing a few trivial conflicts, also removes >> the definition of struct tracepoint_action_ops, which is now unused, but >> was left in by the original patch. > > Thanks. > >> >> I'm also not sure if I got the changelog format right... >> >> OK to push? >> > > OK with fixes below. > >> - >> static CORE_ADDR >> r_tracepoint_action_download (const struct tracepoint_action *action) >> { >> - int size_in_ipa = (sizeof (struct collect_registers_action) >> - - offsetof (struct tracepoint_action, type)); >> - CORE_ADDR ipa_action = target_malloc (size_in_ipa); >> + CORE_ADDR ipa_action = target_malloc (sizeof (struct collect_registers_action)); >> > > Remove spurious double-space before '=' while at it. > > >> @@ -628,21 +592,14 @@ x_tracepoint_action_send ( char *buffer, const struct tracepoint_action *action) >> return agent_expr_send (buffer, eaction->expr); >> } >> >> -static const struct tracepoint_action_ops x_tracepoint_action_ops = >> -{ >> - x_tracepoint_action_download, >> - x_tracepoint_action_send, >> -}; >> - >> static CORE_ADDR >> l_tracepoint_action_download (const struct tracepoint_action *action) >> { >> - int size_in_ipa = (sizeof (struct collect_static_trace_data_action) >> - - offsetof (struct tracepoint_action, type)); >> - CORE_ADDR ipa_action = target_malloc (size_in_ipa); >> + CORE_ADDR ipa_action = >> + target_malloc (sizeof (struct collect_static_trace_data_action)); > > The '=' goes at the beginning of the next line. > > OK with those fixed. > > Thanks, > Pedro Alves > Thanks, fixed and pushed.