From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106210 invoked by alias); 11 Feb 2016 22:31:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106192 invoked by uid 89); 11 Feb 2016 22:31:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1883, misconfigured, HContent-Transfer-Encoding:8bit X-HELO: xyzzy.0x04.net Received: from xyzzy.0x04.net (HELO xyzzy.0x04.net) (109.74.193.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Feb 2016 22:31:25 +0000 Received: from hogfather.0x04.net (89-65-66-135.dynamic.chello.pl [89.65.66.135]) by xyzzy.0x04.net (Postfix) with ESMTPS id 6288A3FEC0; Thu, 11 Feb 2016 23:32:13 +0100 (CET) Received: from [192.168.13.108] (89-65-66-135.dynamic.chello.pl [89.65.66.135]) by hogfather.0x04.net (Postfix) with ESMTPSA id 0C40F580088; Thu, 11 Feb 2016 23:31:22 +0100 (CET) Subject: Re: [PATCH 1/3] gdb.trace: Save XML target description in tfile. To: Simon Marchi , Pedro Alves , Sergio Durigan Junior References: <56BB34F2.5030403@redhat.com> <1455135521-21767-1-git-send-email-koriakin@0x04.net> <56BBB793.3080108@redhat.com> <56BBBB22.1050405@0x04.net> <56BCDABE.7080008@ericsson.com> Cc: gdb-patches@sourceware.org From: =?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?= Message-ID: <56BD0BBA.8040708@0x04.net> Date: Thu, 11 Feb 2016 22:31:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56BCDABE.7080008@ericsson.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00393.txt.bz2 On 11/02/16 20:02, Simon Marchi wrote: > On 16-02-10 05:35 PM, Marcin Kościelnicki wrote: >> On 10/02/16 23:20, Pedro Alves wrote: >>> On 02/10/2016 08:18 PM, Marcin Kościelnicki wrote: >>>> gdb/ChangeLog: >>>> >>>> * ctf.c (ctf_write_tdesc): New function. >>>> (ctf_write_ops): Wire in ctf_write_tdesc. >>>> * tracefile-tfile.c (tfile_write_tdesc): New function. >>>> (tfile_write_ops): Wire in tfile_write_tdesc. >>>> * tracefile.c (trace_save): Call write_tdesc method. >>>> * tracefile.h (struct trace_file_write_ops): Add write_tdesc method. >>>> * xml-tdesc.c (target_fetch_description_xml): New function. >>>> * xml-tdesc.h: Add target_fetch_description_xml prototype. >>> >>> OK. >>> >>> Thanks, >>> Pedro Alves >>> >> >> Thanks, pushed. >> > > Hi Marcin, > > Did you get an email from Builbot about this patch? > > An unrelated patch did fail because of this one: > http://gdb-build.sergiodj.net/builders/Fedora-i686/builds/3021/steps/compile%20gdb/logs/stdio > > It happens when you build without expat. Maybe this particular slave doesn't have expat-devel > installed, but others do. You can reproduce it locally by configuring with --with-expat=no or > --without-expat. > > @Sergio: To ensure that we always test in the same conditions, perhaps we could add --with-expat, > --with-python, and maybe others? Can it be done on a per-builder basis? > > This way, if the slave for a builder is mis-configured (doesn't have development packages for > those), configure will fail right away. In an ideal world, to catch problems like the current > one though, we should test gdb (at least see if it builds) with various combinations of > with/without python, expat, etc. > I didn't get any email about the breakage before this one. Thanks for noticing that. Sorry for the problem, I'll submit a patch soon.