public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: "Marcin Kościelnicki" <koriakin@0x04.net>
Cc: simon.marchi@ericsson.com, gdb-patches@sourceware.org,
	sergiodj@redhat.com
Subject: Re: [PATCH] gdb: Fix build failure in xml-tdesc.c without expat.
Date: Fri, 12 Feb 2016 10:19:00 -0000	[thread overview]
Message-ID: <56BDB1B9.8070909@redhat.com> (raw)
In-Reply-To: <1455271799-20446-1-git-send-email-koriakin@0x04.net>

On 02/12/2016 10:09 AM, Marcin Kościelnicki wrote:
> Introduced by 18d3cec54e1b4fce278dba436484846f8048d7d6.
> 
> gdb/ChangeLog:
> 
> 	* xml-tdesc.c (target_fetch_description_xml): Warn and return NULL
> 	when built without expat.
> ---
> How about that?

There's a standard CL format for conditionally compiled code:

	* xml-tdesc.c (target_fetch_description_xml) [!HAVE_LIBEXPAT]: Warn
	and return NULL.

OK with that change.

Thanks,
Pedro Alves

  reply	other threads:[~2016-02-12 10:19 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-06 15:39 [PATCH 0/4] Save target description in tfile Marcin Kościelnicki
2016-02-06 15:39 ` [PATCH 3/4] gdb.trace: Use g packet order in tfile_fetch_registers Marcin Kościelnicki
2016-02-10 13:20   ` Pedro Alves
2016-02-10 13:21     ` Marcin Kościelnicki
2016-02-10 13:54       ` Pedro Alves
2016-02-10 14:12         ` [PATCH] " Marcin Kościelnicki
2016-02-10 14:21           ` Pedro Alves
2016-02-10 14:49             ` Marcin Kościelnicki
2016-02-06 15:39 ` [PATCH 1/4] gdb.trace: Save XML target description in tfile Marcin Kościelnicki
2016-02-10 13:02   ` Pedro Alves
2016-02-10 20:18     ` [PATCH 1/3] " Marcin Kościelnicki
2016-02-10 22:20       ` Pedro Alves
2016-02-10 22:35         ` Marcin Kościelnicki
2016-02-11 19:02           ` Simon Marchi
2016-02-11 21:28             ` Sergio Durigan Junior
2016-02-11 22:31             ` Marcin Kościelnicki
2016-02-11 22:56             ` [PATCH] gdb: Fix build failure in xml-tdesc.c without expat Marcin Kościelnicki
2016-02-12 10:06               ` Pedro Alves
2016-02-12 10:10                 ` Marcin Kościelnicki
2016-02-12 10:19                   ` Pedro Alves [this message]
2016-02-12 10:21                     ` Marcin Kościelnicki
2016-02-06 15:39 ` [PATCH 2/4] gdb.trace: Read XML target description from tfile Marcin Kościelnicki
2016-02-10 13:02   ` Pedro Alves
2016-02-10 20:19     ` [PATCH 2/3] " Marcin Kościelnicki
2016-02-10 22:20       ` Pedro Alves
2016-02-10 22:35         ` Marcin Kościelnicki
2016-02-06 15:47 ` [PATCH 4/4] gdb.trace: Fix off-by-one in tfile_fetch_registers Marcin Kościelnicki
2016-02-10 13:22   ` Pedro Alves
2016-02-10 13:53     ` Marcin Kościelnicki
2016-02-06 20:54 ` [PATCH 5/6] gdb/x86: Implement ax_pseudo_register_collect hook Marcin Kościelnicki
2016-02-06 20:54   ` [PATCH 6/6] gdb.trace: Add a testcase for tdesc in tfile Marcin Kościelnicki
2016-02-10 13:50     ` Pedro Alves
2016-02-11 10:14       ` [PATCH] " Marcin Kościelnicki
2016-02-11 13:00         ` Pedro Alves
2016-02-11 14:17           ` Marcin Kościelnicki
2016-02-12 18:32             ` Antoine Tremblay
2016-02-12 18:40               ` Marcin Kościelnicki
2016-02-12 18:49                 ` Antoine Tremblay
2016-02-12 18:53                   ` Marcin Kościelnicki
2016-02-12 18:57                     ` Antoine Tremblay
2016-02-12 19:47                       ` [PATCH] gdb.trace/tfile-avx.c: Change ymm15 to xmm15 for old gcc Marcin Kościelnicki
2016-02-12 19:57                         ` Pedro Alves
2016-02-12 21:34                           ` Marcin Kościelnicki
2016-02-10 13:31   ` [PATCH 5/6] gdb/x86: Implement ax_pseudo_register_collect hook Pedro Alves
2016-02-10 13:34     ` Marcin Kościelnicki
2016-02-10 13:50       ` Pedro Alves
2016-02-10 14:27         ` [PATCH] " Marcin Kościelnicki
2016-02-10 14:28           ` Pedro Alves
2016-02-10 14:49             ` Marcin Kościelnicki
2016-02-10 14:24 ` [PATCH 0/4] Save target description in tfile Pedro Alves
2016-02-10 14:25   ` Marcin Kościelnicki
2016-02-10 20:19   ` [PATCH 3/3] gdb/doc: Add documentation for tfile description section lines Marcin Kościelnicki
2016-02-10 22:20     ` Pedro Alves
2016-02-17  9:50       ` Marcin Kościelnicki
2016-02-17 15:37         ` Pedro Alves
2016-02-17 15:38           ` Pedro Alves
2016-02-17 15:59         ` Eli Zaretskii
2016-02-17 16:04           ` Marcin Kościelnicki
2016-02-17 16:05             ` Pedro Alves
2016-02-18  8:28               ` Marcin Kościelnicki
2016-02-11 17:36 ` [PATCH 0/4] Save target description in tfile Yao Qi
2016-02-12  1:49   ` Marcin Kościelnicki
2016-02-12 12:13     ` Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56BDB1B9.8070909@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=koriakin@0x04.net \
    --cc=sergiodj@redhat.com \
    --cc=simon.marchi@ericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).