From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72084 invoked by alias); 12 Feb 2016 15:29:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 72059 invoked by uid 89); 12 Feb 2016 15:29:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 12 Feb 2016 15:29:58 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 3375FC0C2377; Fri, 12 Feb 2016 15:29:57 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1CFTtX9026318; Fri, 12 Feb 2016 10:29:56 -0500 Message-ID: <56BDFA73.9000001@redhat.com> Date: Fri, 12 Feb 2016 15:29:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Luis Machado , gdb-patches@sourceware.org CC: gbenson@redhat.com Subject: Re: [PATCH] Remote debugging without a binary (regression) References: <1455200365-5270-1-git-send-email-lgustavo@codesourcery.com> In-Reply-To: <1455200365-5270-1-git-send-email-lgustavo@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-02/txt/msg00413.txt.bz2 On 02/11/2016 02:19 PM, Luis Machado wrote: > gdb/ChangeLog: > > 2016-02-11 Luis Machado > > * remote.c (remote_add_inferior): Guard block that can throw > errors. So the question is: why guard this call, and not the others? E.g., I'd think that failing to find the executable in the sysroot shouldn't error out of "attach" either. Thanks, Pedro Alves