From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 130153 invoked by alias); 15 Feb 2016 13:43:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 129902 invoked by uid 89); 15 Feb 2016 13:43:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=Watchpoint, advertise, Hx-languages-length:2173, watchpoint X-HELO: xyzzy.0x04.net Received: from xyzzy.0x04.net (HELO xyzzy.0x04.net) (109.74.193.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 15 Feb 2016 13:43:04 +0000 Received: from hogfather.0x04.net (89-65-66-135.dynamic.chello.pl [89.65.66.135]) by xyzzy.0x04.net (Postfix) with ESMTPS id 07CCA3FE10 for ; Mon, 15 Feb 2016 14:43:53 +0100 (CET) Received: from [192.168.1.62] (84-10-2-59.static.chello.pl [84.10.2.59]) by hogfather.0x04.net (Postfix) with ESMTPSA id 60C4058008A for ; Mon, 15 Feb 2016 14:43:01 +0100 (CET) Subject: Re: [PATCH] gdbserver/s390: Advertise Z0 packet support. To: gdb-patches@sourceware.org References: <1453374480-11047-1-git-send-email-koriakin@0x04.net> <1454852905-17184-1-git-send-email-koriakin@0x04.net> From: =?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?= Message-ID: <56C1D5E4.2030303@0x04.net> Date: Mon, 15 Feb 2016 13:43:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1454852905-17184-1-git-send-email-koriakin@0x04.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00459.txt.bz2 Ping On 07/02/16 14:48, Marcin Kościelnicki wrote: > This is necessary for upcoming tracepoint support - otherwise, setting > a tracepoint and a breakpoint on the same address will fail, since gdbserver > won't know about gdb's breakpoint. > > Tested on s390x-ibm-linux-gnu and s390-ibm-linux-gnu, RHEL 7.2. > > gdb/gdbserver/ChangeLog: > > * linux-s390-low.c (s390_supports_z_point_type): New function. > (struct linux_target_ops): Wire s390_supports_z_point_type in. > --- > I've added missing comment. Ping? > > gdb/gdbserver/ChangeLog | 5 +++++ > gdb/gdbserver/linux-s390-low.c | 18 +++++++++++++++++- > 2 files changed, 22 insertions(+), 1 deletion(-) > > diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog > index fd49585..254341c 100644 > --- a/gdb/gdbserver/ChangeLog > +++ b/gdb/gdbserver/ChangeLog > @@ -1,5 +1,10 @@ > 2016-02-07 Marcin Kościelnicki > > + * linux-s390-low.c (s390_supports_z_point_type): New function. > + (struct linux_target_ops): Wire s390_supports_z_point_type in. > + > +2016-02-07 Marcin Kościelnicki > + > * tracepoint.c (struct tracepoint_action_ops): Removed. > (struct tracepoint_action): Removed ops field. > (struct collect_registers_action): Removed. > diff --git a/gdb/gdbserver/linux-s390-low.c b/gdb/gdbserver/linux-s390-low.c > index 63728aa..533e384 100644 > --- a/gdb/gdbserver/linux-s390-low.c > +++ b/gdb/gdbserver/linux-s390-low.c > @@ -609,6 +609,22 @@ s390_breakpoint_at (CORE_ADDR pc) > return memcmp (c, s390_breakpoint, s390_breakpoint_len) == 0; > } > > +/* Breakpoint/Watchpoint support. */ > + > +/* The "supports_z_point_type" linux_target_ops method. */ > + > +static int > +s390_supports_z_point_type (char z_type) > +{ > + switch (z_type) > + { > + case Z_PACKET_SW_BP: > + return 1; > + default: > + return 0; > + } > +} > + > /* Support for hardware single step. */ > > static int > @@ -687,7 +703,7 @@ struct linux_target_ops the_low_target = { > NULL, > s390_breakpoint_len, > s390_breakpoint_at, > - NULL, /* supports_z_point_type */ > + s390_supports_z_point_type, > NULL, > NULL, > NULL, >