From: Luis Machado <lgustavo@codesourcery.com>
To: Gary Benson <gbenson@redhat.com>
Cc: "'gdb-patches@sourceware.org'" <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Remote debugging without a binary (regression)
Date: Thu, 18 Feb 2016 12:40:00 -0000 [thread overview]
Message-ID: <56C5BBCA.4030501@codesourcery.com> (raw)
In-Reply-To: <20160218123032.GA14534@blade.nx>
Hi Gary,
On 02/18/2016 10:30 AM, Gary Benson wrote:
> Hi Luis,
>
> Luis Machado wrote:
>> The following patch guards such a call to prevent those errors
>> from disrupting a potential debugging session, and display only
>> a warning.
>
> After looking into this it seems your patch is the right way to
> go. There is a separate bug in exec_file_locate_attach in that
> in some cases the sysroot is ignored, but fixing that will not
> remove the need for what you are proposing.
>
> My only nit is that I would prefer the TRY-CATCH block smaller,
> covering just exec_file_locate_attach, like so:
>
> /* If no main executable is currently open then attempt to
> open the file that was executed to create this inferior. */
> if (try_open_exec && get_exec_file (0) == NULL)
> {
> /* exec_file_locate_attach may throw an error...
> TRY
> {
> exec_file_locate_attach (pid, 1);
> }
> CATCH...
>
> Other than that I am ok with this change.
>
> Thanks for tracking this down.
No problem. I'll come up with a new version of the patch and, while at
it, i'll try Pedro's suggestion for the testcase.
prev parent reply other threads:[~2016-02-18 12:40 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 14:19 Luis Machado
2016-02-11 16:35 ` Gary Benson
2016-02-11 17:06 ` Luis Machado
2016-02-11 17:31 ` Pedro Alves
2016-02-11 17:42 ` Luis Machado
2016-02-12 10:31 ` Gary Benson
2016-02-12 10:59 ` Luis Machado
2016-02-12 15:24 ` Pedro Alves
2016-02-17 13:53 ` Gary Benson
2016-02-17 14:40 ` Pedro Alves
2016-02-17 17:02 ` [OB PATCH] Add missing cleanup in exec_file_locate_attach Gary Benson
2016-02-17 17:05 ` Gary Benson
2016-02-17 18:11 ` Luis Machado
2016-02-18 9:54 ` Gary Benson
2016-02-18 17:05 ` [PATCH] Fix logic " Gary Benson
2016-02-18 17:28 ` Pedro Alves
2016-02-19 10:24 ` Gary Benson
2016-02-19 10:33 ` Luis Machado
2016-02-19 11:21 ` [PATCH v2] " Gary Benson
2016-02-19 15:38 ` Luis Machado
2016-02-22 10:40 ` Gary Benson
2016-02-22 11:37 ` Luis Machado
2016-02-22 13:51 ` Gary Benson
2016-02-22 22:00 ` Luis Machado
2016-02-22 22:50 ` Luis Machado
2016-02-22 23:00 ` Pedro Alves
2016-02-23 0:04 ` Luis Machado
2016-02-23 0:13 ` Pedro Alves
2016-02-23 0:16 ` Luis Machado
2016-02-23 11:27 ` Gary Benson
2016-02-23 11:43 ` Pedro Alves
2016-02-23 12:15 ` Gary Benson
2016-02-23 12:20 ` Pedro Alves
2016-02-23 11:55 ` Pedro Alves
2016-02-24 11:56 ` Gary Benson
2016-02-12 15:29 ` [PATCH] Remote debugging without a binary (regression) Pedro Alves
2016-02-12 16:08 ` Luis Machado
2016-02-12 16:36 ` Pedro Alves
2016-02-12 17:31 ` Luis Machado
2016-02-17 11:46 ` Pedro Alves
2016-02-18 12:30 ` Gary Benson
2016-02-18 12:40 ` Luis Machado [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C5BBCA.4030501@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).