From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91260 invoked by alias); 18 Feb 2016 16:58:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91241 invoked by uid 89); 18 Feb 2016 16:58:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=UD:unavailable.exp, unavailable.exp, unavailableexp, HContent-Transfer-Encoding:8bit X-HELO: xyzzy.0x04.net Received: from xyzzy.0x04.net (HELO xyzzy.0x04.net) (109.74.193.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Feb 2016 16:58:32 +0000 Received: from hogfather.0x04.net (89-65-66-135.dynamic.chello.pl [89.65.66.135]) by xyzzy.0x04.net (Postfix) with ESMTPS id ACD3F3FE37; Thu, 18 Feb 2016 17:59:22 +0100 (CET) Received: from [192.168.1.62] (84-10-2-59.static.chello.pl [84.10.2.59]) by hogfather.0x04.net (Postfix) with ESMTPSA id 18B6D58008A; Thu, 18 Feb 2016 17:58:29 +0100 (CET) Subject: Re: [PATCH] gdb/s390: Fill guess_tracepoint_registers hook. To: Ulrich Weigand References: <20160218164806.B27A46B9A@oc7340732750.ibm.com> Cc: arnez@linux.vnet.ibm.com, gdb-patches@sourceware.org From: =?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?= Message-ID: <56C5F834.4000401@0x04.net> Date: Thu, 18 Feb 2016 16:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160218164806.B27A46B9A@oc7340732750.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00554.txt.bz2 On 18/02/16 17:48, Ulrich Weigand wrote: > Marcin Kościelnicki wrote: > >> This version fills PSWM too. This causes two failures in tests when >> combined with the later patches: >> >> - gdb.trace/mi-trace-frame-collected.exp: will have to be changed to expect >> $pswa and $cc to be available. >> - gdb.trace/unavailable.exp: likewise. >> >> An unfortunate side effect is that $cc is now considered available (which >> unavailable.exp rightly complains about). There isn't a way to mark >> individual bitfields as unavailable, is there? > > That's bit unfortunate. Right now there's no way to mark *parts* of > a register a unavailable (this is possible for the value subsystem, > but not for the plain regcache at this point). > > It probably shouldn't matter much to show a defined $cc in those cases. > > Patch is OK. > > Bye, > Ulrich > Thanks, pushed. I will update patch #5 shortly to fix the test issues. FWIW patches #3 and #4 are currently ready for review, while #6-#8 have some pending issues I'll have to fix (Antoine's comment about auxv + making it work with the high GPRs patch + doc comments everywhere).