From: Simon Marchi <simon.marchi@ericsson.com>
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH 07/10] Use struct buffer in gdb_readline_no_editing
Date: Fri, 19 Feb 2016 15:25:00 -0000 [thread overview]
Message-ID: <56C733E4.4080807@ericsson.com> (raw)
In-Reply-To: <1455817236-13642-8-git-send-email-palves@redhat.com>
On 16-02-18 12:40 PM, Pedro Alves wrote:
> gdb/ChangeLog:
> 2016-02-18 Pedro Alves <palves@redhat.com>
>
> * common/buffer.h (buffer_grow_char): New function.
> * top.c: Include buffer.h.
> (gdb_readline_no_editing): Use struct buffer instead of xrealloc.
> ---
> gdb/common/buffer.h | 8 ++++++++
> gdb/top.c | 40 ++++++++++++++++++----------------------
> 2 files changed, 26 insertions(+), 22 deletions(-)
>
> diff --git a/gdb/common/buffer.h b/gdb/common/buffer.h
> index 2a47db4..bad2c3a 100644
> --- a/gdb/common/buffer.h
> +++ b/gdb/common/buffer.h
> @@ -31,6 +31,14 @@ struct buffer
> accommodate the new data. */
> void buffer_grow (struct buffer *buffer, const char *data, size_t size);
>
> +/* Append CH to the end of BUFFER. Grows the buffer to accommodate
Tiny-micro-nit: the actual parameter name is c.
next prev parent reply other threads:[~2016-02-19 15:25 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-18 17:40 [PATCH 00/10] Command line input handling TLC Pedro Alves
2016-02-18 17:40 ` [PATCH 07/10] Use struct buffer in gdb_readline_no_editing Pedro Alves
2016-02-18 22:16 ` Sergio Durigan Junior
2016-03-09 18:40 ` Pedro Alves
2016-02-19 15:25 ` Simon Marchi [this message]
2016-02-22 14:06 ` Yao Qi
2016-02-18 17:40 ` [PATCH 02/10] Garbage collect window_hook Pedro Alves
2016-02-18 21:55 ` Sergio Durigan Junior
2016-02-18 17:40 ` [PATCH 01/10] Test issuing a command split in multiple lines with continuation chars Pedro Alves
2016-02-18 21:53 ` Sergio Durigan Junior
2016-02-24 12:40 ` Luis Machado
2016-03-09 18:38 ` Pedro Alves
2016-02-18 17:40 ` [PATCH 08/10] Use struct buffer in gdb_readline_callback_no_editing Pedro Alves
2016-02-18 22:18 ` Sergio Durigan Junior
2016-02-18 17:40 ` [PATCH 03/10] gdb_readline2 -> gdb_readline_callback_no_editing Pedro Alves
2016-02-18 21:59 ` Sergio Durigan Junior
2016-03-09 18:39 ` Pedro Alves
2016-02-18 17:40 ` [PATCH 06/10] gdb_readline -> gdb_readline_no_editing Pedro Alves
2016-02-18 22:00 ` Sergio Durigan Junior
2016-02-18 17:40 ` [PATCH 09/10] Simplify saved_command_line handling Pedro Alves
2016-02-18 17:46 ` [PATCH 05/10] Update prompt_for_continue comments Pedro Alves
2016-02-22 14:02 ` Yao Qi
2016-03-09 18:39 ` Pedro Alves
2016-02-18 17:49 ` [PATCH 10/10] Command line input handling TLC Pedro Alves
2016-02-19 16:01 ` Simon Marchi
2016-03-09 18:41 ` Pedro Alves
2016-02-24 12:41 ` Luis Machado
2016-02-18 17:49 ` [PATCH 04/10] Eliminate async_annotation_suffix Pedro Alves
2016-02-18 22:57 ` [PATCH 00/10] Command line input handling TLC Sergio Durigan Junior
2016-02-19 16:04 ` Simon Marchi
2016-02-23 8:51 ` Yao Qi
2016-03-09 18:43 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56C733E4.4080807@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).