From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19896 invoked by alias); 22 Feb 2016 13:16:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19810 invoked by uid 89); 22 Feb 2016 13:16:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=bps, iirc, IIRC, paragraph X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 22 Feb 2016 13:16:53 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id A489716B1CF; Mon, 22 Feb 2016 13:16:52 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1MDGpaT016866; Mon, 22 Feb 2016 08:16:51 -0500 Message-ID: <56CB0A42.70507@redhat.com> Date: Mon, 22 Feb 2016 13:16:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Luis Machado , gdb-patches@sourceware.org CC: macro@linux-mips.org Subject: Re: [PATCH, v2] Expect SI_KERNEL or TRAP_BRKPT si_code values for MIPS breakpoint traps References: <1456145829-5052-1-git-send-email-lgustavo@codesourcery.com> In-Reply-To: <1456145829-5052-1-git-send-email-lgustavo@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-02/txt/msg00647.txt.bz2 On 02/22/2016 12:57 PM, Luis Machado wrote: > This is v2 of this patch. It was pre-approved by Maciej and i will commit > it soon if there are no objections. I'd like to have a short paragraph in linux-nat.h about MIPS's behavior, below the ppc comment. If you look at the x86 table above, which cases get SI_KERNEL, and which don't? Single-step is not applicable, since the MIPS doesn't handle single-stepping itself (IIRC), but do we also get SI_KERNEL hardware bps and watchpoints, for example? > Further discussion with MIPS maintainers showed that, historically, MIPS > kernels have never set a proper si_code and thus they use the default value of > SI_KERNEL. > > There are plans to update the MIPS kernel to provide more meaningful si_code > values though, so we should expect both SI_KERNEL and TRAP_BRKPT from now > on, as GDB will handle both correctly, like powerpc. Thanks, Pedro Alves