From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 55935 invoked by alias); 23 Feb 2016 00:13:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 55925 invoked by uid 89); 23 Feb 2016 00:13:58 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=detach X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 23 Feb 2016 00:13:58 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id D867DBCFFC; Tue, 23 Feb 2016 00:13:56 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1N0DtPX021029; Mon, 22 Feb 2016 19:13:55 -0500 Message-ID: <56CBA443.6010106@redhat.com> Date: Tue, 23 Feb 2016 00:13:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Luis Machado , Gary Benson CC: gdb-patches@sourceware.org Subject: Re: [PATCH v2] Fix logic in exec_file_locate_attach References: <20160219102447.GA29870@blade.nx> <1455880879-310-1-git-send-email-gbenson@redhat.com> <56C736ED.9040505@codesourcery.com> <20160222104034.GA31531@blade.nx> <56CAF2E3.7050607@codesourcery.com> <20160222135109.GA2256@blade.nx> <56CB8506.3010602@codesourcery.com> <56CB9095.9090908@codesourcery.com> <56CB9304.9020408@redhat.com> <56CBA220.3000709@codesourcery.com> In-Reply-To: <56CBA220.3000709@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-02/txt/msg00674.txt.bz2 On 02/23/2016 12:04 AM, Luis Machado wrote: > On 02/22/2016 08:00 PM, Pedro Alves wrote: >> On 02/22/2016 10:49 PM, Luis Machado wrote: >>> On 02/22/2016 07:00 PM, Luis Machado wrote: >> >>>> My idea was to guard both exec_file_attach and symbol_file_add_main. We >>>> can't have anything in that function throwing an error that won't be >>>> caught, otherwise the above connection attempt will fail. >>> >>> For the record, you patch does fix the case of native GDB trying to >>> attach to a process without pre-loading a symbol file. We get a >>> multi-frame backtrace as expected. >>> >>> It is the gdb/gdbserver case that still seems to be broken. >>> >> >> Native is also broken as well for unexpectedly aborting the attach >> sequence midway. While "bt" doesn't show it, "detach" does trip on it: >> > Sounds like we're looking into a try/catch block around such functions then? > Yes, I think so. Probably best to make it two separate try/catches, in case the file can't be loaded as executable but succeeds as symbol file, for some reason. Thanks, Pedro Alves