From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 53932 invoked by alias); 23 Feb 2016 11:55:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 53914 invoked by uid 89); 23 Feb 2016 11:55:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 23 Feb 2016 11:55:42 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 874446437E; Tue, 23 Feb 2016 11:55:41 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1NBteBd012720; Tue, 23 Feb 2016 06:55:40 -0500 Message-ID: <56CC48BB.2010408@redhat.com> Date: Tue, 23 Feb 2016 11:55:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org CC: Luis Machado Subject: Re: [PATCH v2] Fix logic in exec_file_locate_attach References: <20160219102447.GA29870@blade.nx> <1455880879-310-1-git-send-email-gbenson@redhat.com> In-Reply-To: <1455880879-310-1-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-02/txt/msg00684.txt.bz2 On 02/19/2016 11:21 AM, Gary Benson wrote: > --- > This commit fixes an error in exec_file_locate_attach where > the main executable could be loaded from outside the sysroot > if a nonempty, non-"target:" sysroot was set but the discovered > executable filename did not exist in that sysroot and did exist > on the main filesystem. > > gdb/ChangeLog: > > * exec.c (exec_file_locate_attach): Do not attempt to > locate main executable locally if not found in sysroot. > > gdb/testsuite/ChangeLog: > > * gdb.base/attach-pie-noexec.exp: Do not expect an error > message on attach. OK. Thanks, Pedro Alves