* [PATCH] arm-tdep.c: Remove unsued "to" parameters
@ 2016-02-23 15:52 Simon Marchi
2016-02-23 15:54 ` Simon Marchi
2016-02-23 17:17 ` Yao Qi
0 siblings, 2 replies; 4+ messages in thread
From: Simon Marchi @ 2016-02-23 15:52 UTC (permalink / raw)
To: gdb-patches; +Cc: Simon Marchi
gdb/ChangeLog:
* arm-tdep.c (arm_decode_svc_copro): Remove "to" parameter.
(thumb_process_displaced_insn): Likewise.
(arm_process_displaced_insn): Adjust calls.
---
gdb/arm-tdep.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c
index 1a3a209..17f6fc6 100644
--- a/gdb/arm-tdep.c
+++ b/gdb/arm-tdep.c
@@ -6741,7 +6741,7 @@ thumb2_decode_ext_reg_ld_st (struct gdbarch *gdbarch, uint16_t insn1,
}
static int
-arm_decode_svc_copro (struct gdbarch *gdbarch, uint32_t insn, CORE_ADDR to,
+arm_decode_svc_copro (struct gdbarch *gdbarch, uint32_t insn,
struct regcache *regs, struct displaced_step_closure *dsc)
{
unsigned int op1 = bits (insn, 20, 25);
@@ -7446,7 +7446,7 @@ thumb_process_displaced_32bit_insn (struct gdbarch *gdbarch, uint16_t insn1,
static void
thumb_process_displaced_insn (struct gdbarch *gdbarch, CORE_ADDR from,
- CORE_ADDR to, struct regcache *regs,
+ struct regcache *regs,
struct displaced_step_closure *dsc)
{
enum bfd_endian byte_order_for_code = gdbarch_byte_order_for_code (gdbarch);
@@ -7487,7 +7487,7 @@ arm_process_displaced_insn (struct gdbarch *gdbarch, CORE_ADDR from,
dsc->wrote_to_pc = 0;
if (!displaced_in_arm_mode (regs))
- return thumb_process_displaced_insn (gdbarch, from, to, regs, dsc);
+ return thumb_process_displaced_insn (gdbarch, from, regs, dsc);
dsc->is_thumb = 0;
dsc->insn_size = 4;
@@ -7518,7 +7518,7 @@ arm_process_displaced_insn (struct gdbarch *gdbarch, CORE_ADDR from,
break;
case 0xc: case 0xd: case 0xe: case 0xf:
- err = arm_decode_svc_copro (gdbarch, insn, to, regs, dsc);
+ err = arm_decode_svc_copro (gdbarch, insn, regs, dsc);
break;
}
--
2.5.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm-tdep.c: Remove unsued "to" parameters
2016-02-23 15:52 [PATCH] arm-tdep.c: Remove unsued "to" parameters Simon Marchi
@ 2016-02-23 15:54 ` Simon Marchi
2016-02-23 17:17 ` Yao Qi
1 sibling, 0 replies; 4+ messages in thread
From: Simon Marchi @ 2016-02-23 15:54 UTC (permalink / raw)
To: gdb-patches
On 16-02-23 10:52 AM, Simon Marchi wrote:
> gdb/ChangeLog:
>
> * arm-tdep.c (arm_decode_svc_copro): Remove "to" parameter.
> (thumb_process_displaced_insn): Likewise.
> (arm_process_displaced_insn): Adjust calls.
> ---
> gdb/arm-tdep.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c
> index 1a3a209..17f6fc6 100644
> --- a/gdb/arm-tdep.c
> +++ b/gdb/arm-tdep.c
> @@ -6741,7 +6741,7 @@ thumb2_decode_ext_reg_ld_st (struct gdbarch *gdbarch, uint16_t insn1,
> }
>
> static int
> -arm_decode_svc_copro (struct gdbarch *gdbarch, uint32_t insn, CORE_ADDR to,
> +arm_decode_svc_copro (struct gdbarch *gdbarch, uint32_t insn,
> struct regcache *regs, struct displaced_step_closure *dsc)
> {
> unsigned int op1 = bits (insn, 20, 25);
> @@ -7446,7 +7446,7 @@ thumb_process_displaced_32bit_insn (struct gdbarch *gdbarch, uint16_t insn1,
>
> static void
> thumb_process_displaced_insn (struct gdbarch *gdbarch, CORE_ADDR from,
> - CORE_ADDR to, struct regcache *regs,
> + struct regcache *regs,
> struct displaced_step_closure *dsc)
> {
> enum bfd_endian byte_order_for_code = gdbarch_byte_order_for_code (gdbarch);
> @@ -7487,7 +7487,7 @@ arm_process_displaced_insn (struct gdbarch *gdbarch, CORE_ADDR from,
> dsc->wrote_to_pc = 0;
>
> if (!displaced_in_arm_mode (regs))
> - return thumb_process_displaced_insn (gdbarch, from, to, regs, dsc);
> + return thumb_process_displaced_insn (gdbarch, from, regs, dsc);
>
> dsc->is_thumb = 0;
> dsc->insn_size = 4;
> @@ -7518,7 +7518,7 @@ arm_process_displaced_insn (struct gdbarch *gdbarch, CORE_ADDR from,
> break;
>
> case 0xc: case 0xd: case 0xe: case 0xf:
> - err = arm_decode_svc_copro (gdbarch, insn, to, regs, dsc);
> + err = arm_decode_svc_copro (gdbarch, insn, regs, dsc);
> break;
> }
>
>
Obviously, s/unsued/unused/ in the subject line.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] arm-tdep.c: Remove unsued "to" parameters
2016-02-23 15:52 [PATCH] arm-tdep.c: Remove unsued "to" parameters Simon Marchi
2016-02-23 15:54 ` Simon Marchi
@ 2016-02-23 17:17 ` Yao Qi
2016-02-23 18:22 ` Simon Marchi
1 sibling, 1 reply; 4+ messages in thread
From: Yao Qi @ 2016-02-23 17:17 UTC (permalink / raw)
To: Simon Marchi; +Cc: gdb-patches
Simon Marchi <simon.marchi@ericsson.com> writes:
> gdb/ChangeLog:
>
> * arm-tdep.c (arm_decode_svc_copro): Remove "to" parameter.
> (thumb_process_displaced_insn): Likewise.
> (arm_process_displaced_insn): Adjust calls.
Patch is OK to me.
--
Yao (齐尧)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] arm-tdep.c: Remove unsued "to" parameters
2016-02-23 17:17 ` Yao Qi
@ 2016-02-23 18:22 ` Simon Marchi
0 siblings, 0 replies; 4+ messages in thread
From: Simon Marchi @ 2016-02-23 18:22 UTC (permalink / raw)
To: Yao Qi; +Cc: gdb-patches
On 16-02-23 12:17 PM, Yao Qi wrote:
> Simon Marchi <simon.marchi@ericsson.com> writes:
>
>> gdb/ChangeLog:
>>
>> * arm-tdep.c (arm_decode_svc_copro): Remove "to" parameter.
>> (thumb_process_displaced_insn): Likewise.
>> (arm_process_displaced_insn): Adjust calls.
>
> Patch is OK to me.
>
Thanks, pushed!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-23 18:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-02-23 15:52 [PATCH] arm-tdep.c: Remove unsued "to" parameters Simon Marchi
2016-02-23 15:54 ` Simon Marchi
2016-02-23 17:17 ` Yao Qi
2016-02-23 18:22 ` Simon Marchi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).