From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1242 invoked by alias); 25 Feb 2016 15:12:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1223 invoked by uid 89); 25 Feb 2016 15:12:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=HContent-Transfer-Encoding:8bit X-HELO: xyzzy.0x04.net Received: from xyzzy.0x04.net (HELO xyzzy.0x04.net) (109.74.193.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Feb 2016 15:12:37 +0000 Received: from hogfather.0x04.net (89-65-66-135.dynamic.chello.pl [89.65.66.135]) by xyzzy.0x04.net (Postfix) with ESMTPS id 5357B3FED6; Thu, 25 Feb 2016 16:13:29 +0100 (CET) Received: from [192.168.13.108] (89-65-66-135.dynamic.chello.pl [89.65.66.135]) by hogfather.0x04.net (Postfix) with ESMTPSA id AC4FD5800FC; Thu, 25 Feb 2016 16:12:34 +0100 (CET) Subject: Re: [PATCH 2/3] gdb.trace: Surround $call_insn with \y in entry-values.exp To: Pedro Alves , gdb-patches@sourceware.org References: <56C7323C.4050707@0x04.net> <1455976932-22255-1-git-send-email-koriakin@0x04.net> <1455976932-22255-2-git-send-email-koriakin@0x04.net> <56CF0D78.8080003@redhat.com> Cc: antoine.tremblay@ericsson.com From: =?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?= Message-ID: <56CF19E2.8050602@0x04.net> Date: Thu, 25 Feb 2016 15:12:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <56CF0D78.8080003@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-02/txt/msg00796.txt.bz2 On 25/02/16 15:19, Pedro Alves wrote: > On 02/20/2016 02:02 PM, Marcin Kościelnicki wrote: >> The PPC64 tracepoint patch added \y at the end of the call_insn pattern - >> without that, it embarassed itself and matched the 'bl' in "Dump of >> assem*bl*er code for function" as the powerpc call opcode. Since that >> sounds like a generally good idea, I've added \y before and after >> call_insn for every target. As a result, I had to change x86_64's mnemonic >> to 'callq'. >> > > OK. > > Thanks, > Pedro Alves > Thanks, pushed.