From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-129921-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 68075 invoked by alias); 25 Feb 2016 16:46:44 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 68058 invoked by uid 89); 25 Feb 2016 16:46:43 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=UD:addr_ipa_tdesc_idx, sk:write_i, UD:ipa_sym_addrs.addr_ipa_tdesc_idx, ipa_tdesc_idx
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 25 Feb 2016 16:46:42 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (Postfix) with ESMTPS id 843C1C0E7223;	Thu, 25 Feb 2016 16:46:41 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1PGkdD3017440;	Thu, 25 Feb 2016 11:46:40 -0500
Message-ID: <56CF2FEF.3090407@redhat.com>
Date: Thu, 25 Feb 2016 16:46:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: =?UTF-8?B?TWFyY2luIEtvxZtjaWVsbmlja2k=?= <koriakin@0x04.net>
CC: gdb-patches@sourceware.org, antoine.tremblay@ericsson.com
Subject: Re: [PATCH] [PR gdb/13808] gdb.trace: Pass tdesc selected in gdbserver to IPA.
References: <56CF13A5.2020909@redhat.com> <1456414790-12228-1-git-send-email-koriakin@0x04.net>
In-Reply-To: <1456414790-12228-1-git-send-email-koriakin@0x04.net>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
X-SW-Source: 2016-02/txt/msg00805.txt.bz2

On 02/25/2016 03:39 PM, Marcin Kościelnicki wrote:
>  
> +  /* Tell IPA about the correct tdesc.  */
> +  if (write_inferior_integer (ipa_sym_addrs.addr_ipa_tdesc_idx,
> +			      target_get_ipa_tdesc_idx ()))
> +    {
> +      error ("Error setting ipa_tdesc_idx variable in lib");
> +    }
> +

No {}s for single-line statement.

Otherwise OK.

Thanks,
Pedro Alves