From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102849 invoked by alias); 25 Feb 2016 17:27:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 102835 invoked by uid 89); 25 Feb 2016 17:27:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=nested X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 25 Feb 2016 17:27:09 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 843E9249; Thu, 25 Feb 2016 17:27:08 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u1PHR7XI023584; Thu, 25 Feb 2016 12:27:07 -0500 Message-ID: <56CF396B.5020501@redhat.com> Date: Thu, 25 Feb 2016 17:27:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 4/8] Step over syscalll insn with disp-step on and off References: <1455892594-2294-1-git-send-email-yao.qi@linaro.org> <1455892594-2294-5-git-send-email-yao.qi@linaro.org> In-Reply-To: <1455892594-2294-5-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-02/txt/msg00810.txt.bz2 LGTM, though minor comments below. On 02/19/2016 02:36 PM, Yao Qi wrote: > + set disp_step_opts { "off" } > + if { [support_displaced_stepping] } { > + lappend disp_step_opts "on" > + } > + > + foreach displaced $disp_step_opts { > + with_test_prefix "displaced $displaced" { > + This can be a single: foreach_with_prefix displaced $disp_step_opts { BTW, I usually write these as: foreach_with_prefix displaced {"off" "on"} { if {$displaced == "on" && ![support_displaced_stepping]} { continue } ... tests or proc call here .. } It makes it easier to scan the testing axis covered, particularly when you have multiple nested foreach loops, IMO. Thanks, Pedro Alves