From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40131 invoked by alias); 15 Mar 2016 12:55:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 40106 invoked by uid 89); 15 Mar 2016 12:55:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=thorough X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 15 Mar 2016 12:55:39 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 2E46B46215; Tue, 15 Mar 2016 12:55:38 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2FCtalW000752; Tue, 15 Mar 2016 08:55:37 -0400 Subject: Re: [PATCH v2 2/3] PR remote/19496, interrupted syscall in forking-threads-plus-bkpt To: Don Breazeal , gdb-patches@sourceware.org References: <1455150484-12600-1-git-send-email-donb@codesourcery.com> From: Pedro Alves Message-ID: <56E80648.4000703@redhat.com> Date: Tue, 15 Mar 2016 12:55:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <1455150484-12600-1-git-send-email-donb@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-03/txt/msg00231.txt.bz2 Hi Don, On 02/11/2016 12:28 AM, Don Breazeal wrote: > So, the bottom line is that I haven't changed the fix for the interrupted > system calls, because I can't find anything that works as well as the > original fix. Perhaps this test puts enough stress on the kernel that the > kernel bugs mentioned above are exposed. Many thanks for the thorough investigation. Let's take your original approach then. > > One change I did make from the previous version was to increase the > timeout to 90 seconds, which was necessary to get more reliable results > on the Nios II target. > diff --git a/gdb/testsuite/gdb.threads/forking-threads-plus-breakpoint.exp b/gdb/testsuite/gdb.threads/forking-threads-plus-breakpoint.exp > index ff3ca9a..6889c2b 100644 > --- a/gdb/testsuite/gdb.threads/forking-threads-plus-breakpoint.exp > +++ b/gdb/testsuite/gdb.threads/forking-threads-plus-breakpoint.exp > @@ -73,6 +73,9 @@ proc do_test { cond_bp_target detach_on_fork displaced } { > global linenum > global is_remote_target > > + global timeout > + set timeout 90 > + Use with_timeout_factor instead so that the timeout is properly restored, and put it around the problematic test, only, instead of basically around the whole test case. I think that'll be the "inferior 1 exited" test? > set saved_gdbflags $GDBFLAGS > set GDBFLAGS [concat $GDBFLAGS " -ex \"set non-stop on\""] > clean_restart $binfile Thanks, Pedro Alves