From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51697 invoked by alias); 16 Mar 2016 22:28:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51685 invoked by uid 89); 16 Mar 2016 22:28:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 16 Mar 2016 22:28:30 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id EF613B8BBE; Wed, 16 Mar 2016 22:28:28 +0000 (UTC) Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2GMSS3V015898 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 16 Mar 2016 18:28:28 -0400 Subject: Re: [PATCH v3 07/11] [PR gdb/14441] gdb: dwarf2read: support DW_AT_rvalue_reference type To: Artemiy Volkov , gdb-patches@sourceware.org References: <1453229609-20159-1-git-send-email-artemiyv@acm.org> <1457147955-21871-1-git-send-email-artemiyv@acm.org> <1457147955-21871-8-git-send-email-artemiyv@acm.org> From: Keith Seitz Message-ID: <56E9DE0C.4080500@redhat.com> Date: Wed, 16 Mar 2016 22:28:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1457147955-21871-8-git-send-email-artemiyv@acm.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00277.txt.bz2 On 03/04/2016 07:19 PM, Artemiy Volkov wrote: > Make gdb DWARF reader understand the DW_AT_rvalue_reference type tag. Handling > of this tag is done in the existing read_tag_reference_type() function, to > which we add a new parameter representing the kind of reference type > (lvalue vs rvalue). > > gdb/ChangeLog: > > 2016-03-03 Artemiy Volkov > > * dwarf2read.c (process_die, read_type_die_1): Handle the > DW_AT_rvalue_reference_type DIE. ^^^^^^^^^^^^^^^^^^^^^^^^^^^ > (read_tag_reference_type): Add new parameter "refcode". DW_TAG_rvalue_reference_type? > --- > gdb/dwarf2read.c | 15 +++++++++++---- > 1 file changed, 11 insertions(+), 4 deletions(-) Otherwise this looks good to me. Keith