From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71764 invoked by alias); 29 Mar 2016 21:40:51 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71680 invoked by uid 89); 29 Mar 2016 21:40:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=news, HContent-Transfer-Encoding:8bit X-HELO: xyzzy.0x04.net Received: from xyzzy.0x04.net (HELO xyzzy.0x04.net) (159.100.250.38) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 29 Mar 2016 21:40:49 +0000 Received: from hogfather.0x04.net (89-65-66-135.dynamic.chello.pl [89.65.66.135]) by xyzzy.0x04.net (Postfix) with ESMTPS id 613B61A3BB; Tue, 29 Mar 2016 21:40:46 +0000 (UTC) Received: from [172.21.36.130] (unknown [88.214.186.105]) by hogfather.0x04.net (Postfix) with ESMTPSA id F397E5800F8; Tue, 29 Mar 2016 23:40:45 +0200 (CEST) Subject: Re: [PATCH v4] gdbserver/s390: Switch on tracepoint support. To: Ulrich Weigand References: <20160329183052.BAAEDC9C7@oc7340732750.ibm.com> Cc: Andreas Arnez , gdb-patches@sourceware.org, Keith Seitz From: =?UTF-8?Q?Marcin_Ko=c5=9bcielnicki?= Message-ID: <56FAF65C.50703@0x04.net> Date: Tue, 29 Mar 2016 21:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <20160329183052.BAAEDC9C7@oc7340732750.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2016-03/txt/msg00538.txt.bz2 On 29/03/16 20:30, Ulrich Weigand wrote: > Marcin Kościelnicki wrote: >> On 23/03/16 16:25, Andreas Arnez wrote: >>> On Tue, Mar 15 2016, Marcin Kościelnicki wrote: >>> >>>> Also adds s390 support to gdb.trace testsuite. >>>> >>>> gdb/gdbserver/ChangeLog: >>>> >>>> * linux-s390-low.c (s390_supports_tracepoints): New function. >>>> (struct linux_target_ops): Fill supports_tracepoints hook. >>>> >>>> gdb/testsuite/ChangeLog: >>>> >>>> * gdb.trace/ftrace.exp: Set arg0exp for s390. >>>> * gdb.trace/mi-trace-frame-collected.exp: Expect 4 registers on s390. >>>> * gdb.trace/mi-trace-unavailable.exp: Set pcnum for s390, add gpr0num >>>> variable for GPR 0 instead of assuming it is register 0. >>>> * gdb.trace/trace-common.h: Add s390 fast tracepoint placeholder. >>>> * lib/trace-support.exp: Add s390 registers. >>>> --- >>>> This fixes a minor conflict with the powerpc regular tracepoint support >>>> pushed in the meantime (mi-trace-unavailable.exp now needs gpr0num in >>>> powerpc branch). >>> >>> Please also document this new feature in the NEWS file. >> >> OK, I'll submit another patch adding the NEWS entry (it should go after >> the fast tracepoints). > >>> Otherwise the patch looks good to me. But I think a global- or >>> testsuite-maintainer should approve the changes to the testsuite. > > Those changes are OK. > > Thanks, > Ulrich > Thanks, pushed.