Re: [PATCH] Make ftrace tests work with remote targets

[Pedro Alves <palves@redhat.com>]

On 03/03/2016 09:22 PM, Simon Marchi wrote:
> --- a/gdb/testsuite/lib/gdb.exp
> +++ b/gdb/testsuite/lib/gdb.exp
> @@ -3374,7 +3374,7 @@ proc gdb_compile {source dest type options} {
>      # dynamically load one by basename, we must specify rpath.  If we
>      # are using a remote host, DejaGNU will link to the shared library
>      # using a relative path, so again we must specify an rpath.
> -    if { $shlib_load || ($shlib_found && [is_remote target]) } {
> +    if { $shlib_load || $shlib_found } {

I think the comment above needs updating.

>  	    lappend link_options "additional_flags=-Wl,--out-implib,${name}.a"
> -	} elseif [is_remote target] {
> +	} else {
>  	    # By default, we do not set the soname.  This causes the linker

Likewise.


>  proc gdb_load_shlibs { args } {
> -    if {![is_remote target]} {
> -	return
> -    }
> +    if {[is_remote target]} {
> +	foreach file $args {
> +	    # When the target is remote, we simply send the file to the target.
> +	    gdb_download [shlib_target_file $file]
> +	}
> +    } else {
> +	foreach from $args {
> +	    # When the target is native, we copy the files to the test directory
> +	    # (next to the executable), except if that's already where it is.
> +	    set to [standard_output_file [file tail $from]]

I'd think it better to make the gdb_download path work for native
testing as well.  WDYT?  E.g., make shlib_target_file default to
return the test directory path?

> # Even if the target supplies full paths for shared libraries,
> # they may not be paths for this system.
> gdb_test "set solib-search-path [file dirname [lindex $args 0]]" "" ""

Can we skip this command on native testing?

I'm worried that that command might paper over, or cause, issues with
sysroot / dso path lookup.  Normal native debugging usage will not specify
that command, so if we could avoid it, I'd prefer it, on grounds of
testing what users normally use.  

Thanks,
Pedro Alves