From: Simon Marchi <simon.marchi@ericsson.com>
To: Yao Qi <qiyaoltc@gmail.com>
Cc: <gdb-patches@sourceware.org>, Par Olsson <par.olsson@windriver.com>
Subject: Re: [PATCH 1/2] Fix write endianness/size problem for fast tracepoint enabled flag
Date: Thu, 31 Mar 2016 17:45:00 -0000 [thread overview]
Message-ID: <56FD624A.20800@ericsson.com> (raw)
In-Reply-To: <86oa9urkcm.fsf@gmail.com>
On 16-03-31 06:51 AM, Yao Qi wrote:
> Simon Marchi <simon.marchi@ericsson.com> writes:
>
>> I am sending this fix on behalf of Par Olsson, as a follow-up of this
>> one:
>>
>> https://www.sourceware.org/ml/gdb-patches/2015-10/msg00196.html
>
> Hi Simon,
> The patch in the url above is to change 'enabled' field to uint32_t, so
> I guess you got the patch below from Par Olsson off list?
>
> The reason I ask this is that I find the author doesn't have the copyright
> assignment. We can take it as a tiny patch, if no one has objections.
Par indeed sent us this off-list. But as Pedro mentioned, Wind River is covered.
>
>> static int
>> +write_inferior_int8 (CORE_ADDR symaddr, int8_t val)
>> +{
>> + return write_inferior_memory (symaddr, (unsigned char *) &val, sizeof (val));
>
> This line is too long.
It's 79 characters long, no? It's the same line as the line in write_inferior_integer,
I think they are both ok.
> The patch itself is good to me.
Ok thanks, I'll push it when the corresponding test is accepted.
next prev parent reply other threads:[~2016-03-31 17:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 15:17 Simon Marchi
2016-03-30 15:17 ` [PATCH 2/2] Add test for fast tracepoint enable/disable Simon Marchi
2016-03-31 10:58 ` Yao Qi
2016-03-31 18:01 ` Simon Marchi
2016-03-31 18:31 ` Simon Marchi
2016-04-01 13:36 ` Yao Qi
2016-04-01 14:42 ` Simon Marchi
2016-04-28 15:30 ` Simon Marchi
2016-04-28 16:03 ` Yao Qi
2016-04-28 16:57 ` Simon Marchi
2016-03-31 10:51 ` [PATCH 1/2] Fix write endianness/size problem for fast tracepoint enabled flag Yao Qi
2016-03-31 11:33 ` Pedro Alves
2016-03-31 12:58 ` Yao Qi
2016-03-31 17:45 ` Simon Marchi [this message]
2016-05-05 7:58 ` Yao Qi
2016-05-05 13:50 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FD624A.20800@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=par.olsson@windriver.com \
--cc=qiyaoltc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).