From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90189 invoked by alias); 31 Mar 2016 23:18:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90177 invoked by uid 89); 31 Mar 2016 23:18:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=grounds, 160329, transferring, you! X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 31 Mar 2016 23:18:35 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B8F0515558; Thu, 31 Mar 2016 23:18:34 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u2VNIXga024623; Thu, 31 Mar 2016 19:18:34 -0400 Subject: Re: [PATCH] Make ftrace tests work with remote targets To: Simon Marchi , gdb-patches@sourceware.org References: <1457040175-24438-1-git-send-email-simon.marchi@ericsson.com> <56FB05C9.8050801@redhat.com> <56FD8762.2030909@ericsson.com> From: Pedro Alves Message-ID: <56FDB049.9070405@redhat.com> Date: Thu, 31 Mar 2016 23:18:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <56FD8762.2030909@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-03/txt/msg00613.txt.bz2 On 03/31/2016 09:24 PM, Simon Marchi wrote: > On 16-03-29 06:46 PM, Pedro Alves wrote: >> On 03/03/2016 09:22 PM, Simon Marchi wrote: >>> --- a/gdb/testsuite/lib/gdb.exp >>> +++ b/gdb/testsuite/lib/gdb.exp >>> @@ -3374,7 +3374,7 @@ proc gdb_compile {source dest type options} { >>> # dynamically load one by basename, we must specify rpath. If we >>> # are using a remote host, DejaGNU will link to the shared library >>> # using a relative path, so again we must specify an rpath. >>> - if { $shlib_load || ($shlib_found && [is_remote target]) } { >>> + if { $shlib_load || $shlib_found } { >> >> I think the comment above needs updating. > > What about: > > # Because we link with libraries using their basename, we may need > # (depending on the platform) to set a special rpath value, to allow > # the executable to find the libraries it depends on. That's great. > >>> lappend link_options "additional_flags=-Wl,--out-implib,${name}.a" >>> - } elseif [is_remote target] { >>> + } else { >>> # By default, we do not set the soname. This causes the linker >> >> Likewise. > > What about: > > # Set the soname of the library. This causes the linker on ELF > # systems to create the DT_NEEDED entry in the executable referring > # to the soname of the library, and not its absolute path. This > # (using the absolute path) would be problem when testing on a > # remote target. > # > # In conjunction with setting the soname, we add the special > # rpath=$ORIGIN value when building the executable, so that it's > # able to find the library in its own directory. Perfect. > > >>> proc gdb_load_shlibs { args } { >>> - if {![is_remote target]} { >>> - return >>> - } >>> + if {[is_remote target]} { >>> + foreach file $args { >>> + # When the target is remote, we simply send the file to the target. >>> + gdb_download [shlib_target_file $file] >>> + } >>> + } else { >>> + foreach from $args { >>> + # When the target is native, we copy the files to the test directory >>> + # (next to the executable), except if that's already where it is. >>> + set to [standard_output_file [file tail $from]] >> >> I'd think it better to make the gdb_download path work for native >> testing as well. WDYT? E.g., make shlib_target_file default to >> return the test directory path? > > If I understand correctly, gdb_download would take a local file path and take > care of transferring that file to the "runtime test directory", whether it's > local or remote. Right. I'm not sure whether it's the right level or not. If the target is local, it checks whether $src == $dest, and > copies the file if not. Basically, the same as my implementation of > gdb_load_shlibs, just not limited to shlibs. *nod* Now that I grep for gdb_download, sounds like we'll need to change mi_load_shlibs similarly. Not sure offhand why the jit*.so hits don't use gdb_load_shlibs instead or gdb_download > > I am not sure if "make shlib_target_file default to return the test directory path?" > would be ok. I think it's meant to return the local file path to download to the > target. You're right. I added those for SymbianOS years ago, since that target had a post link step to convert elf to pe/dll, and it'd be the latter that'd be copied to the target. IIRC. > So gdb_load_shlibs would then become: > > proc gdb_load_shlibs { args } { > foreach file $args { > gdb_download [shlib_target_file $file] > } > } > > I just tested it quickly and it seems to work fine. But I also noticed that there > might be some overlap in feature between gdb_download and gdb_remote_download, so > perhaps I can try to merge them, WDYT? > Indeed. >>> # Even if the target supplies full paths for shared libraries, >>> # they may not be paths for this system. >>> gdb_test "set solib-search-path [file dirname [lindex $args 0]]" "" "" >> >> Can we skip this command on native testing? >> >> I'm worried that that command might paper over, or cause, issues with >> sysroot / dso path lookup. Normal native debugging usage will not specify >> that command, so if we could avoid it, I'd prefer it, on grounds of >> testing what users normally use. > > Makes sense. I'll add that, with a comment explaining why. > > Thanks! > Thank you! -- Pedro Alves