From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) by sourceware.org (Postfix) with ESMTPS id 36CC13858C50 for ; Thu, 31 Mar 2022 09:57:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 36CC13858C50 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f42.google.com with SMTP id d7so32968545wrb.7 for ; Thu, 31 Mar 2022 02:57:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=DJ3UYO99dzZ5HQDA6uOS+I5A0SwOB/OvesdjknS5kQw=; b=SNjdtWfJpJ4ZXzpSWRHjVouTRND1I+5IP50KnaVNBzwOACMdKBa6+O8m14TFCJOe11 2cmplcPEt7cV0UpQ6s46sfBn2Tbw0VIepHaBwUSgwykqi7yvY8oz6ENfsrwhXr2lfghc OAEAibMCp5pbJX3mS4UuS3ltee+dc1J6GQFhvtQ0J5cUXDZpQf4LINrdXth9H8NDo/VN ecX6glMaysUoJMxMoL3mTj3xekbaP2RW2VTWoF67GEHYkIi1WEuIE+/LhLrnoy84KZYf IZfhy/LiEmPOVtYcLyAUyrb3nC7IybQZwYR92AUx2owIywM7r/69aSOpf/4Xbk6VpS57 ZRCA== X-Gm-Message-State: AOAM533XOT0GvUkn15wwq3gvfUsjvfrvqCNq4JEw+9XMM4AirZ9oBThc 69Ladoc8CEKRiceLjAjeSFBr/XIDw9qpWw== X-Google-Smtp-Source: ABdhPJz48ttGXsfbR17JzlNtCRjJq3bF9JcVKXQ1P38/uqhjMpC/JsRl5QzdPUrhs8V1PFkmwwNYow== X-Received: by 2002:a05:6000:1704:b0:203:f042:156d with SMTP id n4-20020a056000170400b00203f042156dmr3565073wrc.164.1648720625144; Thu, 31 Mar 2022 02:57:05 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id m13-20020a05600c3b0d00b0038cda9f92fasm7548344wms.0.2022.03.31.02.57.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 31 Mar 2022 02:57:04 -0700 (PDT) Message-ID: <56ac247b-3777-d480-0d8e-507c899a8db9@palves.net> Date: Thu, 31 Mar 2022 10:57:03 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 1/2] gdb/buildsym: Line record use a record flag Content-Language: en-US To: Lancelot SIX , gdb-patches@sourceware.org Cc: lsix@lancelotsix.com References: <20220330093458.148497-1-lancelot.six@amd.com> <20220330093458.148497-2-lancelot.six@amd.com> From: Pedro Alves In-Reply-To: <20220330093458.148497-2-lancelot.six@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Mar 2022 09:57:07 -0000 On 2022-03-30 10:34, Lancelot SIX via Gdb-patches wrote: > @@ -21220,7 +21223,9 @@ lnp_state_machine::record_line (bool end_sequence) > > if (!end_sequence && !ignore_this_line) > { > - bool is_stmt = producer_is_codewarrior (m_cu) || m_is_stmt; > + linetable_entry_flags lte_flags = m_flags; > + if (producer_is_codewarrior (m_cu)) > + lte_flags |= LEF_IS_STMT; > > if (dwarf_record_line_p (m_cu, m_line, m_last_line, > m_line_has_non_zero_discriminator, Hmm, seems like "lte_flags" ends up used. > @@ -21229,7 +21234,7 @@ lnp_state_machine::record_line (bool end_sequence) > buildsym_compunit *builder = m_cu->get_builder (); > dwarf_record_line_1 (m_gdbarch, > builder->get_current_subfile (), > - m_line, m_address, is_stmt, > + m_line, m_address, m_flags, I guess you meant to pass down lte_flags instead of m_flags here? > m_currently_recording_lines ? m_cu : nullptr); > } > m_last_subfile = m_cu->get_builder ()->get_current_subfile (); Otherwise LGTM.