From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 24EF4385801D for ; Tue, 22 Feb 2022 13:46:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 24EF4385801D Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 21MDkqMG021738 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 22 Feb 2022 08:46:57 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 21MDkqMG021738 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id AC2061F0E7; Tue, 22 Feb 2022 08:46:52 -0500 (EST) Message-ID: <56b3a9a2-7807-62cf-c1a5-604ddb5864d8@polymtl.ca> Date: Tue, 22 Feb 2022 08:46:52 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v2] gdb/testsuite/README: point to default value of INTERNAL_GDBFLAGS Content-Language: en-US To: Philippe Blain , gdb-patches@sourceware.org References: <20220219234029.28070-1-levraiphilippeblain@gmail.com> <20220220164912.87471-1-levraiphilippeblain@gmail.com> From: Simon Marchi In-Reply-To: <20220220164912.87471-1-levraiphilippeblain@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 22 Feb 2022 13:46:53 +0000 X-Spam-Status: No, score=-3033.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Feb 2022 13:47:00 -0000 On 2022-02-20 11:49, Philippe Blain via Gdb-patches wrote: > The INTERNAL_GDBFLAGS runtest variable was updated in 55c3ad88013 > ([gdb/testsuite] Prevent pagination in GDB_INTERNALFLAGS, 2020-10-26) to > disable pagination, and in aae1c79a03a (PR python/12227..., 2010-12-07) > to point to the data directory, but its default value mentioned in the > testsuite's README was not kept up to date. > > To avoid it getting out of sync even more, point the reader to the > definition of the variable in lib/gdb.exp, and move the explanation of > the different flags there. Also adjust the example in the README > so it follows the flags added in 55c3ad88013. Thanks, this is ok. If you plan on contributing more patches, it would be useful for you to get push access so you can push patches once they are approved. Would you prefer that? Simon