From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id C13B63858D1E for ; Mon, 6 Feb 2023 16:53:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C13B63858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 096EC60695; Mon, 6 Feb 2023 16:53:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1675702389; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XMQxMuzqesJYOdGRxHDFE/y2gvrAWpIiDfOuog5OK8I=; b=HVA3JQVr38yxnOZK1jP3zz6F/+oAtQK6NbC2gwC515F7f8u4y6qalz1Wcf5TYoENMhT0GE oxlyZDGNGQjuWv9S+T0ymVNzIgUyIOIMVZrdZQpmzk/bYBPs++zbC4mNOgwpuY3bLf/YbP B2iNZrLoAlO7iL3vnXjBcukXyfglfIw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1675702389; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XMQxMuzqesJYOdGRxHDFE/y2gvrAWpIiDfOuog5OK8I=; b=1+B6NvCl7ZVw7wOlcb2zZEQ5liPKKHIbnWf7NUWzmrWVf/Lc4WdQIgsilN2SlGsf7Uhh2W VrHuF8qAW/Yc/iAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DD245138E8; Mon, 6 Feb 2023 16:53:08 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id UNXPNHQw4WO8HAAAMHmgww (envelope-from ); Mon, 06 Feb 2023 16:53:08 +0000 Content-Type: multipart/alternative; boundary="------------QyERF654DJiz2kGtZBlQU8Hm" Message-ID: <56bec06d-b9ce-a6a7-b30d-18433c009694@suse.de> Date: Mon, 6 Feb 2023 17:53:07 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 0/8] Initial support for ROCm platform (AMD GPU) debugging To: Lancelot Six , Simon Marchi , Simon Marchi , gdb-patches@sourceware.org References: <20230105200237.987771-1-simon.marchi@polymtl.ca> <5f28702a-53a9-1e8c-88d2-85e020e3b3f2@polymtl.ca> Content-Language: en-US From: Tom de Vries In-Reply-To: X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------QyERF654DJiz2kGtZBlQU8Hm Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/6/23 15:01, Lancelot Six wrote: > Hi, > > Thanks for, letting us know. I am preparing a patch to fix this (skip > the tests if the amd-dbgapi support is not built in or if the hiccc > compiler for amdgpu is not available). > > I hope to send this tomorrow. > Thanks for working on this. FWIW, I just tried the same test-case on openSUSE Tumbleweed, and ran into some kind of "no usable compiler found" message. After adding c++ to the compile flags, I ran into the same error as described below. Thanks, - Tom > Best > Lancelot > > Le 6 février 2023 11:47:55 GMT+00:00, Tom de Vries > a écrit : > > On 2/2/23 16:08, Simon Marchi via Gdb-patches wrote: > >> On 1/25/23 12:03, Simon Marchi via Gdb-patches wrote: >>> On 1/5/23 15:02, Simon Marchi wrote: >>>> This is the v2 of: >>>> >>>> https://inbox.sourceware.org/gdb-patches/20221206135729.3937767-1-simon.marchi@efficios.com/ >>>> >>>> I pushed patches 5, 7, 8 and 9, since I considered them good chances even >>>> outside of this series. >>>> >>>> Most other preparatory patches have been reviewed and LGTM'ed by Andrew >>>> Burgess, but they are not really useful on their own, so they are still >>>> in this series. There are no changes in them, except a typo fix in >>>> patch 3. >>>> >>>> The only preparatory patch which was not reviewed is "gdb/solib-svr4: >>>> don't disable probes interface if probe not found". >>> Ping. >>> >>> I plan to push the series in a week from now, if there are no more >>> comments on this. Note that this code has been heavily scrutinized by >>> Pedro and Lancelot, so I am confident that it is in good shape already. >>> >>> Simon >> I pushed the series. >> >> Simon > > > Hi, > > as I mentioned earlier to Lancelot off-list, I'm now seeing: > > ... > > Running /data/vries/gdb/src/gdb/testsuite/gdb.rocm/simple.exp ... > gdb compile failed, > /data/vries/gdb/src/gdb/testsuite/gdb.rocm/simple.cpp:18:10: fatal > error: hip/hip_runtime.h: No such file or directory > #include "hip/hip_runtime.h" >          ^~~~~~~~~~~~~~~~~~~ > compilation terminated. > ... > > Thanks, > > - Tom > --------------QyERF654DJiz2kGtZBlQU8Hm--