From: Simon Marchi <simon.marchi@polymtl.ca>
To: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] Add a better diagnostic message in mi_gdb_test
Date: Thu, 20 Oct 2016 04:24:00 -0000 [thread overview]
Message-ID: <56fdb3e37cf79fdbc9a4620616e6a77b@simark.ca> (raw)
In-Reply-To: <1473712054-30417-2-git-send-email-marc-andre.laperle@ericsson.com>
On 2016-09-12 16:27, Marc-Andre Laperle wrote:
> When using mi_gdb_test, if it fails because of the presence of
> unexpected output, the error message is only the message passed as
> the argument with no indication that there was an unexpected output.
> This change adds an additional text to the failure message to
> indicate that there was an unexpected output.
>
> gdb/testsuite/ChangeLog:
>
> * lib/mi-support.exp (mi_gdb_test): Add additional message
> for unexpected output.
>
> Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
> ---
> gdb/testsuite/lib/mi-support.exp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/testsuite/lib/mi-support.exp
> b/gdb/testsuite/lib/mi-support.exp
> index 7c2bb3e..25995cf 100644
> --- a/gdb/testsuite/lib/mi-support.exp
> +++ b/gdb/testsuite/lib/mi-support.exp
> @@ -824,7 +824,7 @@ proc mi_gdb_test { args } {
> }
> -re ".*$mi_gdb_prompt\[ \]*$" {
> if ![string match "" $message] then {
> - fail "$message"
> + fail "$message (unexpected output)"
> }
> set result 1
> }
Looks good to me, more details do not hurt. If it wasn't clear for you,
it probably wasn't for some other people too.
next prev parent reply other threads:[~2016-10-20 4:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 20:28 [PATCH 1/3] Remove unused parameter in solib_add and update_solib_list Marc-Andre Laperle
2016-09-12 20:28 ` [PATCH 3/3] Add -file-list-shared-libraries MI command Marc-Andre Laperle
2016-10-14 21:20 ` Marc-André Laperle
2016-10-20 5:05 ` Simon Marchi
2016-11-23 13:06 ` Pedro Alves
2017-01-04 17:19 ` Marc-André Laperle
2017-01-12 16:15 ` Pedro Alves
2016-09-12 20:28 ` [PATCH 2/3] Add a better diagnostic message in mi_gdb_test Marc-Andre Laperle
2016-10-20 4:24 ` Simon Marchi [this message]
2016-11-23 13:03 ` Pedro Alves
2016-10-20 4:20 ` [PATCH 1/3] Remove unused parameter in solib_add and update_solib_list Simon Marchi
2016-11-23 13:03 ` Pedro Alves
2017-02-03 17:17 ` [PATCH v2 0/3] Shared libraries MI command Marc-Andre Laperle
2017-02-03 17:16 ` [PATCH v2 1/3] Remove unused parameter in solib_add and update_solib_list Marc-Andre Laperle
2017-02-03 17:16 ` [PATCH v2 3/3] Add -file-list-shared-libraries MI command Marc-Andre Laperle
2017-02-06 12:40 ` Pedro Alves
2017-02-28 22:08 ` [Patch v3] " Marc-Andre Laperle
2017-03-01 15:50 ` Marc-André Laperle
2017-03-01 16:12 ` Eli Zaretskii
2017-03-01 16:38 ` [Patch v4] " Marc-Andre Laperle
2017-03-01 17:09 ` Eli Zaretskii
2017-03-02 14:56 ` [Patch v5] " Marc-Andre Laperle
2017-03-09 19:12 ` Marc-André Laperle
2017-03-17 16:55 ` Pedro Alves
2017-03-20 19:07 ` Marc-André Laperle
2017-02-03 17:16 ` [PATCH v2 2/3] Add a better diagnostic message in mi_gdb_test Marc-Andre Laperle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56fdb3e37cf79fdbc9a4620616e6a77b@simark.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=marc-andre.laperle@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).