From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82635 invoked by alias); 5 Apr 2016 17:57:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 82606 invoked by uid 89); 5 Apr 2016 17:57:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 05 Apr 2016 17:57:00 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F2C401204B4; Tue, 5 Apr 2016 17:56:58 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u35HuvD7026836; Tue, 5 Apr 2016 13:56:58 -0400 Subject: Re: [PATCH v2 1/2] Improve gdb_remote_download, remove gdb_download To: Simon Marchi , gdb-patches@sourceware.org References: <1459794657-2087-1-git-send-email-simon.marchi@ericsson.com> <5703FA26.2080907@redhat.com> <5703FBD7.7020706@ericsson.com> From: Pedro Alves Message-ID: <5703FC69.7010806@redhat.com> Date: Tue, 05 Apr 2016 17:57:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <5703FBD7.7020706@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00096.txt.bz2 On 04/05/2016 06:54 PM, Simon Marchi wrote: > On 16-04-05 01:47 PM, Pedro Alves wrote: >> Shouldn't this be, "When the DEST is remote, we simply send the >> file to DEST" ?. > > Right. > >>> >>> -# gdb_download >>> -# >>> -# Copy a file to the remote target and return its target filename. >>> -# Schedule the file to be deleted at the end of this test. >>> + set destname [remote_download target $fromfile $tofile] >> >> and thus here be "remote_download $dest" ? > > Right. I tested this procedure with a remote host, but with the target being > the same as the host, so it was working anyway... > > Fixed. OK with those fixed then. Thanks, Pedro Alves