From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33871 invoked by alias); 11 Apr 2016 14:10:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 33833 invoked by uid 89); 11 Apr 2016 14:10:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Deliver X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 11 Apr 2016 14:10:03 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6008164D16; Mon, 11 Apr 2016 14:10:02 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3BEA1H5031874; Mon, 11 Apr 2016 10:10:01 -0400 Subject: Re: [PATCH 2/7] Deliver signal in hardware single step To: Yao Qi , gdb-patches@sourceware.org References: <1458749384-19793-1-git-send-email-yao.qi@linaro.org> <1458749384-19793-3-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: <570BB039.1060806@redhat.com> Date: Mon, 11 Apr 2016 14:10:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1458749384-19793-3-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00208.txt.bz2 On 03/23/2016 04:09 PM, Yao Qi wrote: > +++ b/gdb/testsuite/gdb.trace/signal.exp > @@ -166,7 +166,15 @@ while { $loop } { > > for { set i 0 } { $i < [expr 20] } { incr i } { > if {[info exists tracepoint_hits($i)]} { > - gdb_assert { $tracepoint_hits($i) == $iterations } \ > - "tracepoint $i hit $iterations times" > + > + if { $tracepoint_hits($i) == $iterations } { > + pass "tracepoint $i hit $iterations times" > + } elseif { $tracepoint_hits($i) > $iterations } { > + # GDBserver delivers the signal while stepping over tracepoint, > + # so it is possible that a tracepoint is collected twice. > + pass "tracepoint $i hit $iterations times: spurious collection" I think this will make some test runs print, e.g.: pass "tracepoint 2 hit 4 times: spurious collection" while others runs print: pass "tracepoint 2 hit 4 times" making test result diffing unstable. If so, I think it should either be written as: pass "tracepoint $i hit $iterations times (spurious collection)" making use of the rule that terminating " (...)" bits don't really count as test message, or always: pass "tracepoint $i hit $iterations times" Otherwise LGTM. Thanks, Pedro Alves