From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1661 invoked by alias); 11 Apr 2016 15:29:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1648 invoked by uid 89); 11 Apr 2016 15:29:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 11 Apr 2016 15:29:34 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D1C7F64062; Mon, 11 Apr 2016 15:29:32 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3BFTVgE021138; Mon, 11 Apr 2016 11:29:32 -0400 Subject: Re: [PATCH 6/7] Resume the inferior with signal rather than stepping over To: Yao Qi , gdb-patches@sourceware.org References: <1458749384-19793-1-git-send-email-yao.qi@linaro.org> <1458749384-19793-7-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: <570BC2DB.9070400@redhat.com> Date: Mon, 11 Apr 2016 15:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1458749384-19793-7-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00214.txt.bz2 On 03/23/2016 04:09 PM, Yao Qi wrote: > When GDBserver steps over a breakpoint using software single step, it > enqueues the signal, single step and deliver the signal in the next > resume if step over is not needed. In this way, the program won't > receive the signal if the conditional breakpoint is set a branch to > self instruction, because the step over is always needed. > > This patch removes the restriction that don't deliver the signal to > the inferior if we are trying to reinsert a breakpoint for software > single step and change the decision on resume vs. step-over when the > LWP has pending signals to deliver. > > gdb/gdbserver: > > 2016-03-23 Yao Qi > > * linux-low.c (LWP_SIGNAL_CAN_BE_DELIVERED): Adjust. It's not longer a macro. :-) > (need_step_over_p): Return zero if the LWP has pending signals > can be delivered on software single step target. OK. Thanks, Pedro Alves