From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25870 invoked by alias); 11 Apr 2016 15:34:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25851 invoked by uid 89); 11 Apr 2016 15:34:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 11 Apr 2016 15:34:38 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 18EEAE8AE3; Mon, 11 Apr 2016 15:34:37 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3BFYZc3014437; Mon, 11 Apr 2016 11:34:36 -0400 Subject: Re: [PATCH 7/7] New test case gdb.base/branch-to-self.exp To: Yao Qi , gdb-patches@sourceware.org References: <1458749384-19793-1-git-send-email-yao.qi@linaro.org> <1458749384-19793-8-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: <570BC40B.1000908@redhat.com> Date: Mon, 11 Apr 2016 15:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1458749384-19793-8-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00215.txt.bz2 On 03/23/2016 04:09 PM, Yao Qi wrote: > +#if defined(__arm__) || defined(__aarch64__) > +#define BRANCH_INSN "b" > +#elif defined(__x86_64__) || defined(__i386__) > +#define BRANCH_INSN "jmp" It's nice when these are indented, like: #if defined(__arm__) || defined(__aarch64__) # define BRANCH_INSN "b" #elif defined(__x86_64__) || defined(__i386__) # define BRANCH_INSN "jmp" > +#else Did you mean to put something here? #error perhaps? I wonder whether we should just use while (1); > +with_test_prefix "single-step" { > + global testfile > + > + clean_restart ${testfile} > + if ![runto_main] { > + return -1 > + } > + set line_num [gdb_get_line_number "loop-line" ${testfile}.c] > + > + gdb_test "break ${testfile}.c:${line_num}" Please avoid line numbers in test messages, as they'll change as the test evolves in future. > + gdb_continue_to_breakpoint "hit breakpoint" > + gdb_test "si" ".*${testfile}.c:${line_num}.*" > +} > + > +with_test_prefix "break-cond" { > + global testfile > + > + foreach_with_prefix side {"host" "target"} { > + > + clean_restart ${testfile} > + > + if ![runto_main] { > + return -1 > + } > + > + set test "set breakpoint condition-evaluation $side" > + gdb_test_multiple $test $test { > + -re "warning: Target does not support breakpoint condition evaluation.\r\nUsing host evaluation mode instead.\r\n$gdb_prompt $" { > + # Target doesn't support breakpoint condition > + # evaluation on its side. Skip the test. > + continue > + } > + -re "^$test\r\n$gdb_prompt $" { > + } > + } > + > + set line_num [gdb_get_line_number "loop-line" ${testfile}.c] > + gdb_test "break ${testfile}.c:${line_num} if counter > 3" Likewise. > + > + gdb_continue_to_breakpoint "continue to break" > + > + gdb_test "p counter" ".* = 5" > + } > +} > Otherwise LGTM. Thanks, Pedro Alves