From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82343 invoked by alias); 11 Apr 2016 21:29:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 82332 invoked by uid 89); 11 Apr 2016 21:29:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=TCL, Hx-languages-length:1322, sourced X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 11 Apr 2016 21:29:06 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 10BB63D1; Mon, 11 Apr 2016 21:29:05 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3BLT33a031238; Mon, 11 Apr 2016 17:29:04 -0400 Subject: Re: [PATCH 1/4] native-gdbserver: Clear isremote flag in board info To: Simon Marchi , Simon Marchi , gdb-patches@sourceware.org References: <1459912543-15328-1-git-send-email-simon.marchi@polymtl.ca> <570BEF8B.70203@redhat.com> <570BF79F.2070409@ericsson.com> From: Pedro Alves Message-ID: <570C171F.7040603@redhat.com> Date: Mon, 11 Apr 2016 21:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <570BF79F.2070409@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00226.txt.bz2 On 04/11/2016 08:14 PM, Simon Marchi wrote: > On 16-04-11 02:40 PM, Pedro Alves wrote: >> On 04/06/2016 04:15 AM, Simon Marchi wrote: >> OOC, don't we need the "global" declarations as >> in native-extended-gdbserver.exp? > > Apparently not, since it works :) > :-) > I'm not familiar enough with TCL to know that. Are we executing in the body > of a procedure at this point? This file is sourced from some proc in DejaGnu, > so I'd say yes, but this example may suggest otherwise. Hmm, that's probably search_and_load_file, which does "uplevel #0 source ...", meaning top-level global variables are visible in the sourced file. >> You're probably already thinking of doing this, but I'll state it >> explicitly anyway: it'd be nice to move this isremote frobbing to >> a shared .exp file, so that boards that need it can just >> source the file. > > I wasn't, but it's a good idea. isremote is also handled in an unintuitive way, > since the testsuite only checks if it's defined. So when you set isremote to 0, > it's still considered as "true". Hmm, that sounds like a bug. If that were generally true, then native-gdbserver.exp's isremote hacks in ${board}_spawn / ${board}_exec wouldn't work? Where are you seeing that? Thanks, Pedro Alves