From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108768 invoked by alias); 13 Apr 2016 12:05:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108754 invoked by uid 89); 13 Apr 2016 12:05:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Includes, letter X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 13 Apr 2016 12:05:39 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B4B5F13A55F; Wed, 13 Apr 2016 12:05:37 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3DC5Zd7005478; Wed, 13 Apr 2016 08:05:36 -0400 Subject: Re: [PATCH V2 1/2] Add redundant target descriptor for tdesc(amd64|i386)_avx_mpx_* To: Walfred Tedeschi , brobecker@adacore.com References: <1457025942-23711-1-git-send-email-walfred.tedeschi@intel.com> <1457025942-23711-2-git-send-email-walfred.tedeschi@intel.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <570E360F.7060501@redhat.com> Date: Wed, 13 Apr 2016 12:05:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <1457025942-23711-2-git-send-email-walfred.tedeschi@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00269.txt.bz2 On 03/03/2016 05:25 PM, Walfred Tedeschi wrote: > Add a redundant target description for the MPX and AVX case using a > combined feature name to reflect that, i.e. avx-mpx. It's better when commit logs are self-contained and don't depend on info in the cover letter. The cover letter doesn't make it to git. E.g., ~~ Subject: Add target descriptions for AVX + MPX The current MPX target descriptions assume that MPX is always combined with AVX, however that's not correct. We can have machines with MPX and without AVX; or machines with AVX and without MPX. This patch adds new target descriptions for machines that support both MPX and AVX, as duplicates of the existing MPX descriptions. The following commit will remove AVX from the MPX-only descriptions. ~~ (Note s/descriptors/descriptions in subject) > > Usage of both series of target descriptor (avx-mpx and mpx) were also fixed. I don't understand what this means. > +++ b/gdb/features/i386/i386-avx-mpx-linux.xml > @@ -0,0 +1,19 @@ > + > + > + > + Missing space before "-". (Please audit the other added files.) > +++ b/gdb/features/i386/i386-avx-mpx.xml > @@ -0,0 +1,17 @@ > + > + > + > + Shouldn't this say "and AVX" as well? > + > + > + > + i386 > + > + > + > + > + > diff --git a/gdb/gdbserver/Makefile.in b/gdb/gdbserver/Makefile.in > + case X86_XSTATE_AVX_MPX_MASK: > + if (is_x32) > + return tdesc_x32_linux; /* No AVX and MPX is not available in x32. */ The comment sounds odd to me. Does this intend to say: /* Neither AVX nor MPX are available on x32. */ ? Is it really true that x32 does not support AVX? Thanks, Pedro Alves