From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id F2B94384AB52 for ; Tue, 23 Apr 2024 15:30:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F2B94384AB52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F2B94384AB52 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713886216; cv=none; b=an6xW7AWdj8vKudriw/m7BPOrelxLOj274piVosK7B2kcdjKmd1qTOmMBi47JT7VeChJmIiwix3b5Ykqvdm31gwzmrH/ndMZVmcM39bEFQ36vq/oQ9dCvZLDAP1jeZrgidK/UGO+Av89ps/Wg3Vem4Lr9xFOMRJ1pGCSpMW0TYM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1713886216; c=relaxed/simple; bh=Rzal6AMVZHPOmQpEGQJ1M+RF3LJ/HjqQgmLg8dJsEQY=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=qumUXVKEAHjNtWs9IoX7xrDTmWe7Ghk/QkZcK+No1PXBM4RWScQf0JObfY+0PFED9ZJoi/Y27fi/5KSE73MmyT9JxQIb6NQcnyVIsL4YK2cyIVZuGvSSg0hVXH8U+olbFvRYY3/3TTMfhFj3XikpBVmlsiJwTfAUxs+73Chh5tQ= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 43NFU8w4107188 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 23 Apr 2024 11:30:13 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 43NFU8w4107188 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1713886213; bh=gzj42vkbC4VCjwJn0eXciQlg2U/j2yYe3pyUxn73g6Q=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=aNnKSVZ6Wj6sY8q65Rjq+d/XROcTzAC4gZAJW6yyhDjuAJNVvUyzHpWfD3UDqcP+K lN2Dt3BvUNzqFegj88x+mDF1CYlw/kYYxP4mBsTQ6JRtkiSqn9Nso06UXu90u77sez 4TuN0k/t9siO7rz4Q4QJYgcDObo+rKB48Rt/YrBU= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 5024F1E0AC; Tue, 23 Apr 2024 11:30:08 -0400 (EDT) Message-ID: <5715fb2b-48cd-4b3f-ada4-9e7073ab7ca9@polymtl.ca> Date: Tue, 23 Apr 2024 11:30:07 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 0/7] More cleanup of defs.h To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20240423132517.2625632-1-simon.marchi@polymtl.ca> <87frvcqg2q.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <87frvcqg2q.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 23 Apr 2024 15:30:08 +0000 X-Spam-Status: No, score=-3031.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2024-04-23 11:00, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> Some more cleanup of defs.h. I tested this on the buildbot, but it's > Simon> very possible that it breaks the build on untested platforms. If this > Simon> happens, the fix should be one include away. > > This all looks good to me. Thank you. > > Approved-By: Tom Tromey Thanks, pushed. > Simon> gdb/utils.c | 41 ------------------- > > Shrinking utils.[ch] is always good as well. 👍️ Simon