From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-131147-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 55180 invoked by alias); 22 Apr 2016 13:10:26 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 55143 invoked by uid 89); 22 Apr 2016 13:10:22 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=reserved
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 22 Apr 2016 13:10:19 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id 279837F096;	Fri, 22 Apr 2016 13:10:18 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3MDAHwi019772;	Fri, 22 Apr 2016 09:10:17 -0400
Subject: Re: [PATCH] [ARM] Clear reserved bits in CPSR
To: Yao Qi <qiyaoltc@gmail.com>, gdb-patches@sourceware.org
References: <1461320654-22274-1-git-send-email-yao.qi@linaro.org>
From: Pedro Alves <palves@redhat.com>
Message-ID: <571A22B8.8050002@redhat.com>
Date: Fri, 22 Apr 2016 13:10:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1
MIME-Version: 1.0
In-Reply-To: <1461320654-22274-1-git-send-email-yao.qi@linaro.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2016-04/txt/msg00519.txt.bz2

On 04/22/2016 11:24 AM, Yao Qi wrote:
> +      regs[ARM_CPSR_GREGNUM] = 0xff0fffff & regs[ARM_CPSR_GREGNUM];

No comments on the ARM specifics, but I think it's clearer to write
this as:

     regs[ARM_CPSR_GREGNUM] &= 0xff0fffff;

Thanks,
Pedro Alves