From: Pedro Alves <palves@redhat.com>
To: Andreas Arnez <arnez@linux.vnet.ibm.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Avoid non-C++-enabled babeltrace versions
Date: Wed, 27 Apr 2016 12:02:00 -0000 [thread overview]
Message-ID: <5720AA62.7040505@redhat.com> (raw)
In-Reply-To: <m3twinuxbs.fsf@oc1027705133.ibm.com>
On 04/27/2016 12:04 PM, Andreas Arnez wrote:
> In some babeltrace versions before 1.2.0, the header file iterator.h is
> not fully enabled for use from C++, since it contains an anonymous enum
> in a struct declaration. This is fixed in later babeltrace versions:
>
> https://lists.lttng.org/pipermail/lttng-dev/2013-September/021411.html
>
The rationale for that commit is actually wrong. There's nothing
wrong with anonymous enums in structs in C++, and being anonymous is
actually irrelevant. The problem is that a struct/class establishes a scope
in C++, but not in C. So outside the struct, to refer to the enum values,
you'd have to write bt_iter_pos::BT_SEEK_TIME etc.
Anyway ...
> Now that GDB is compiled with C++, the GDB build fails on a system with
> such a babeltrace version: the compiler complains about a missing
> declaration of BT_SEEK_BEGIN in ctf.c.
>
> This patch enhances the configure check to recognize such babeltrace
> versions as unusable for GDB.
>
> gdb/ChangeLog:
>
> * configure.ac: Enhance configure check for babeltrace to reject
> non-C++-enabled versions.
> * configure: Regenerate.
OK.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2016-04-27 12:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 11:16 Andreas Arnez
2016-04-27 12:02 ` Pedro Alves [this message]
2016-04-27 14:24 ` Andreas Arnez
2016-07-03 15:43 ` [patch] babeltrace compilation regression [Re: [PATCH] Avoid non-C++-enabled babeltrace versions] Jan Kratochvil
2016-07-04 8:39 ` Andreas Arnez
2016-07-05 8:50 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5720AA62.7040505@redhat.com \
--to=palves@redhat.com \
--cc=arnez@linux.vnet.ibm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).