From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31152 invoked by alias); 27 Apr 2016 12:02:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31132 invoked by uid 89); 27 Apr 2016 12:02:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 27 Apr 2016 12:02:44 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6AC56C05E154; Wed, 27 Apr 2016 12:02:43 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3RC2gJH015321; Wed, 27 Apr 2016 08:02:42 -0400 Subject: Re: [PATCH] Avoid non-C++-enabled babeltrace versions To: Andreas Arnez , gdb-patches@sourceware.org References: From: Pedro Alves Message-ID: <5720AA62.7040505@redhat.com> Date: Wed, 27 Apr 2016 12:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-04/txt/msg00588.txt.bz2 On 04/27/2016 12:04 PM, Andreas Arnez wrote: > In some babeltrace versions before 1.2.0, the header file iterator.h is > not fully enabled for use from C++, since it contains an anonymous enum > in a struct declaration. This is fixed in later babeltrace versions: > > https://lists.lttng.org/pipermail/lttng-dev/2013-September/021411.html > The rationale for that commit is actually wrong. There's nothing wrong with anonymous enums in structs in C++, and being anonymous is actually irrelevant. The problem is that a struct/class establishes a scope in C++, but not in C. So outside the struct, to refer to the enum values, you'd have to write bt_iter_pos::BT_SEEK_TIME etc. Anyway ... > Now that GDB is compiled with C++, the GDB build fails on a system with > such a babeltrace version: the compiler complains about a missing > declaration of BT_SEEK_BEGIN in ctf.c. > > This patch enhances the configure check to recognize such babeltrace > versions as unusable for GDB. > > gdb/ChangeLog: > > * configure.ac: Enhance configure check for babeltrace to reject > non-C++-enabled versions. > * configure: Regenerate. OK. Thanks, Pedro Alves