From: Simon Marchi <simon.marchi@ericsson.com>
To: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] ftrace: Fix gdbserver crash when doing tstatus after detach or process exit
Date: Thu, 28 Apr 2016 17:28:00 -0000 [thread overview]
Message-ID: <5722482F.20904@ericsson.com> (raw)
In-Reply-To: <57224295.6050504@ericsson.com>
On 16-04-28 01:04 PM, Simon Marchi wrote:
>> +# Check that the target supports trace.
>> +if { [gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile executable $options] != "" } {
I just saw that I used gdb_compile_pthreads. As Yao mentioned in another thread,
it should be gdb_compile instead.
>> + untested "Couldn't compile test program"
>> + return -1
>> +}
>> +
>> +clean_restart ${testfile}
>> +
>> +if ![runto_main] {
>> + fail "Can't run to main to check for trace support"
>> + return -1
>> +}
>> +
>> +if $use_gdb_stub {
>> + # This test is about testing commands after detaching from a process or
>> + # after letting a process exit, so it doesn't make sense to run it if the
>> + # target is stub-like.
>> + unsupported "This test is not supported for GDB stub targets."
>> + return -1
>> +}
>> +
>> +if ![gdb_target_supports_trace] {
>> + unsupported "target does not support trace"
>> + return -1
>> +}
>> +
>> +# Compile the test case with the in-process agent library.
>> +set libipa [get_in_proc_agent]
>> +gdb_load_shlibs $libipa
>> +
>> +lappend options shlib=$libipa
>> +
>> +if { [gdb_compile_pthreads "$srcdir/$subdir/$srcfile" $binfile executable $options] != "" } {
Same here.
next prev parent reply other threads:[~2016-04-28 17:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 13:20 Simon Marchi
2016-04-28 17:04 ` Simon Marchi
2016-04-28 17:28 ` Simon Marchi [this message]
2016-04-29 12:10 ` Yao Qi
2016-04-29 12:46 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5722482F.20904@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).