From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101532 invoked by alias); 3 May 2016 09:01:34 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 100417 invoked by uid 89); 3 May 2016 09:01:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 May 2016 09:01:23 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6C1903A; Tue, 3 May 2016 02:01:27 -0700 (PDT) Received: from [10.2.206.43] (e100706-lin.cambridge.arm.com [10.2.206.43]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 78EE53F21A; Tue, 3 May 2016 02:01:21 -0700 (PDT) Message-ID: <572868DF.4080800@foss.arm.com> Date: Tue, 03 May 2016 09:01:00 -0000 From: Kyrill Tkachov User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH][gdb] Fix -Wparentheses warnings References: <57237D3A.2050203@foss.arm.com> <55918437-8fb0-3d99-645a-667339829bc8@redhat.com> <5bafc0fe-a620-ab2b-82c6-4ba77fd9a7eb@redhat.com> In-Reply-To: <5bafc0fe-a620-ab2b-82c6-4ba77fd9a7eb@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2016-05/txt/msg00031.txt.bz2 Hi Pedro, On 02/05/16 18:03, Pedro Alves wrote: > On 05/02/2016 11:57 AM, Pedro Alves wrote: >> On 04/29/2016 04:26 PM, Kyrill Tkachov wrote: >> Bah. That's written that way exactly to avoid dangling if/else >> problems. >> >> I think it'd be reasonable for gcc to not warn when the if/else >> came from a macro, as users of the macro can't possibly be confused >> in the way the warning intents to help with. I'd call it a >> gcc regression. >> I see what you mean. I filed GCC bug https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70922 to get the GCC devs opinion. > ... > >>> Is this ok to commit? >> OK. > > I suspect this may be the same as PR20029: > > https://sourceware.org/bugzilla/show_bug.cgi?id=20029 > > Could you push it to the gdb-7.11-branch branch too, please? I've pushed the patch to master and gdb-7.11-branch. I've not used the sourceware bugzilla before (I don't have an account there AFAIK), so if someone could confirm that the warnings are fixed and close that accordingly I'd appreciate it. Kyrill > Thanks, > Pedro Alves >